Configuration for Update rating on input#27
Closed
cajoy wants to merge 2 commits intoguymorita:masterfrom
cajoy:master
Closed
Configuration for Update rating on input#27cajoy wants to merge 2 commits intoguymorita:masterfrom cajoy:master
cajoy wants to merge 2 commits intoguymorita:masterfrom
cajoy:master
Conversation
Owner
There was a problem hiding this comment.
Thanks for the PR! Do you think it makes sense to put this in config if you're going to be toggling it multiple times during it's use. I think it belongs more as an optional parameter.
Author
There was a problem hiding this comment.
Yes - take a look at lib/input.js line 15.
it will rating update will trigger on each call If you not put it in config
There was a problem hiding this comment.
I PR-ed a version with each request option instead of config. - #41
guymorita
force-pushed
the
master
branch
4 times, most recently
from
2fddc96 to
3709adb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#26