Skip to content

Configuration for Update rating on input #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cajoy wants to merge 2 commits into from
Closed

Configuration for Update rating on input #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb165e5
Implemented config to update rating separately
cajoy Mar 12, 2015
6fb1834
Updated docs
cajoy Mar 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ raccoon.recommendFor('chrisId', 10, function(results){
raccoon.config.nearestNeighbors = 5; // number of neighbors you want to compare a user against
raccoon.config.className = 'movie'; // prefix for your items (used for redis)
raccoon.config.numOfRecsStore = 30; // number of recommendations to store per user
raccoon.config.updateRatingOnInput = true; // update recommendations on each input
Copy link
Copy Markdown
Owner

@guymorita guymorita Apr 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Do you think it makes sense to put this in config if you're going to be toggling it multiple times during it's use. I think it belongs more as an optional parameter.

Copy link
Copy Markdown
Author

@cajoy cajoy Apr 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - take a look at lib/input.js line 15.

it will rating update will trigger on each call If you not put it in config

Copy link
Copy Markdown

@gabriel-alecu gabriel-alecu Mar 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I PR-ed a version with each request option instead of config. - #41

raccoon.config.factorLeastSimilarLeastLiked = false; // if you want to factor in items that
// users least similar didn't like

Expand Down
1 change: 1 addition & 0 deletions lib/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ function Config (){
this.className = 'movie';
this.numOfRecsStore = 30;
this.factorLeastSimilarLeastLiked = false;
this.updateRatingOnInput = true;
}

module.exports = exports = new Config();
8 changes: 6 additions & 2 deletions lib/input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,13 @@ var updateSequence = function(userId, itemId, callback){
});
},
function(cb){
algo.updateRecommendationsFor(userId, function(){
if (config.updateRatingOnInput) {
algo.updateRecommendationsFor(userId, function(){
cb(null);
});
} else {
cb(null);
});
};
}
],
function(err){
Expand Down
1 change: 1 addition & 0 deletions lib/raccoon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ Raccoon.prototype.config = config;
Raccoon.prototype.stat = stat;
Raccoon.prototype.liked = input.liked;
Raccoon.prototype.disliked = input.disliked;
Raccoon.prototype.updateRecommendationsFor = algo.updateRecommendationsFor;
Raccoon.prototype.recommendFor = stat.recommendFor;
Raccoon.prototype.bestRated = stat.bestRated;
Raccoon.prototype.worstRated = stat.worstRated;
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "raccoon",
"author": "Guy Morita",
"description": "A Collaborative Filtering Recommendation Engine for Node.js utilizing Redis",
"version": "0.2.3",
"version": "0.2.4",
"repository": {
"type": "git",
"url": "https://github.com/guymorita/recommendationRaccoon.git"
Expand Down