remove convenience dependencies of docker and buildah#10340
Open
remove convenience dependencies of docker and buildah#10340
Conversation
Signed-off-by: Matt Wrock <matt@mattwrock.com>
👷 Deploy Preview for chef-habitat processing.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Docker/Buildah from the runtime dependencies of the hab-pkg-export-container Habitat package so the exporter no longer bundles those container engines and instead expects them to be available on the host PATH.
Changes:
- Remove
core/buildahandcore/dockerfrom the Linux plan’spkg_deps. - Remove
core/dockerfrom the Windows plan’spkg_deps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| components/pkg-export-container/habitat/plan.sh | Drops Docker/Buildah as runtime deps by emptying pkg_deps. |
| components/pkg-export-container/habitat/plan.ps1 | Drops Docker as a runtime dep, leaving only the VC++ redistributable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes buildah and docker as runtime deps of the container exporter. We bundle those as a convenience but including this has become burdensome due to the CVEs in their GO ecosystem and not having direct control over them. Any user interested in leveraging docker or buildah is likely going to have these already installed anyways. If they are not installed, the user will get an error message stating that the container engine is missing from the PATH.