Skip to content

WAVE Accessibility - Contrast Ratio Fixes#2747

Merged
entrotech merged 9 commits into
developfrom
2533-fix-contrast-ratios
Dec 4, 2025
Merged

WAVE Accessibility - Contrast Ratio Fixes#2747
entrotech merged 9 commits into
developfrom
2533-fix-contrast-ratios

Conversation

@nchanyal

@nchanyal nchanyal commented Nov 2, 2025

Copy link
Copy Markdown
Member

What changes did you make?

  • Change asterisks color in TDM Feedback Form page
  • Change validation text color in Create New Account page

Why did you make the changes (we will use this info to test)?

  • "Ensures the TDM calculator is accessible to users with visual impairments and meets legal compliance requirements for public-facing applications."

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Feedback Page

Without annotations

before-ss-1

With WAVE annotations:
Image

Create Account Page

Without WAVE annotations:
before-ss-3

With WAVE annotations:
Image

Visuals after changes are applied

Feedback Page

Without annotations
after-ss-1
With WAVE annotations
Image

Create Account Page

Without annotations
after-ss-3

With WAVE annotations
Image

@nchanyal nchanyal added the role: front-end Front End Developer label Nov 2, 2025
Comment thread client/src/components/Authorization/SendEmailForm.jsx Outdated
Comment thread client/src/components/Faq/FaqView.jsx Outdated
Comment thread client/src/components/ProjectWizard/TdmCalculationWizard.jsx Outdated
@nchanyal nchanyal assigned nchanyal and unassigned nchanyal Nov 3, 2025
@eburdekin
eburdekin marked this pull request as draft November 6, 2025 02:53
@rayneng

rayneng commented Nov 7, 2025

Copy link
Copy Markdown
Member

@nchanyal I suggest we create and use new entries in client/src/styles/theme.js under colors.secondary:

  • darkGrey: #4A4A4A
  • slateGrey: #525252
  • darkRed: #990000

This will allow you to avoid using hard-coded values. Please make this change and also be prepared to discuss your change to the react-router-dom includes at the upcoming dev meeting on Wednesday (2025-11-12).

@nchanyal

nchanyal commented Nov 8, 2025

Copy link
Copy Markdown
Member Author

@ryanfchase Sure, I'll add those changes and update the branch.

If you have any particular questions about the changes made to react-router-dom, feel free to ask them here, but the changes I made have actually recently been merged by John in PR #2757. When I was working on my issue, I couldn't run the app without replacing the useBlocker hook, so that's what I did to complete the ticket. I apologize if that's not what's usually done, as this was the first time I came across a bug before starting a ticket.

@eburdekin
eburdekin marked this pull request as draft November 20, 2025 03:04
@nchanyal
nchanyal marked this pull request as ready for review November 24, 2025 22:41

@rayneng rayneng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, approved 👍🏼

@nchanyal

Copy link
Copy Markdown
Member Author

@ryanfchase Thanks. Are there any changes you wanted? The PR says you're requesting a change.

@rayneng rayneng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, didn't mean to request changes. But thank you for providing screenshots. This PR is good to merge.

@geolunalg geolunalg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@entrotech
entrotech merged commit a2ea6cb into develop Dec 4, 2025
7 checks passed
@entrotech
entrotech deleted the 2533-fix-contrast-ratios branch December 4, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

role: front-end Front End Developer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev: WAVE Accessibility - Contrast Ratio Fixes

4 participants