Fixed missing URL for Upload and Download #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
refer to #758 (comment)
In short:
URL is missing when download and upload links are fetched in
SeafConnection.java#getDownloadLinkandSeafConnection.java#getUploadLink.I can confirm that this restores basic file download and upload functionality.
However, there are other instances in this class where links might be generated (e.g.
deleteShareLink,getShareLink, etc) that should be looked at by someone who is familiar with these methods.I am still unsure why the URL is missing, but I kept it generic and only add it in case it is really missing,
i.e.
if (!result.startsWith("http")) {.Best regards,
Firefly