Skip to content

fix: allow coercion of string booleans with trailing whitespace #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marsup merged 2 commits into from
Nov 19, 2025
+10 −1
Merged

fix: allow coercion of string booleans with trailing whitespace #3092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43e8367
fix: handle whitespace in boolean string coercion
Oct 28, 2025
aa1f2b0
Remove empty string to false coercion in boolean validation
Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/types/boolean.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ module.exports = Any.extend({
}

if (typeof value === 'string') {
const normalized = schema._flags.sensitive ? value : value.toLowerCase();
const trimmedValue = value.trim();
const normalized = schema._flags.sensitive ? trimmedValue : trimmedValue.toLowerCase();
value = normalized === 'true' ? true : (normalized === 'false' ? false : value);
}

Expand Down
8 changes: 8 additions & 0 deletions test/types/boolean.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@ describe('boolean', () => {
]);
});

it('converts boolean string with trailing spaces to a boolean', () => {

Helper.validate(Joi.boolean(), [
['true ', true, true],
['false ', true, false]
]);
});

it('does not convert boolean string to a boolean in strict mode', () => {

Helper.validate(Joi.boolean().strict(), [
Expand Down