fix: allow coercion of string booleans with trailing whitespace #3092
+10
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses issue #3091 by improving the coercion behavior of Joi.boolean() for string inputs with trailing whitespace.
Problem
Currently, Joi.boolean().validate('true ') fails with a validation error, even though Joi.number().validate('123 ') successfully coerces the string to a number. This inconsistency creates friction when validating user input from forms, query params, or loosely formatted sources where trailing whitespace is common.
Solution
This update trims string inputs before coercion in the boolean type, aligning its behavior with number. It ensures that:
js
Joi.boolean().validate('true ') // → { value: true }
Joi.boolean().validate('false ') // → { value: false }
Tests
Unit tests have been added to cover:
"true " → true
"false " → false
" true " → true
"false" → false (unchanged)
"yes" → still invalid
Documentation
No breaking changes. Behavior is now more permissive and consistent with other coercive types.