Issue #2 tuning #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali1234
suggested changes
Mar 28, 2021
| @@ -653,6 +654,9 @@ static int cxadc_probe(struct pci_dev *pci_dev, | |||
| /* set gain of agc but not offset */ | |||
| cx_write(MO_AGC_GAIN_ADJ3, (0x28<<16)|(0x28<<8)|(0x50<<0)); | |||
|
|
|||
| /* Disable PLL adjust (stabilizes output when video is detected by chip) */ | |||
| cx_write(MO_PLL_ADJ_CTRL, cx_read(MO_PLL_ADJ_CTRL) & ~(0x0<<25)); | |||
There was a problem hiding this comment.
This line doesn't alter the value of MO_PLL_ADJ_CTRL. It should be ~(0x1<<25) to set PLL_ADJ_EN to 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.