Skip to content

Issue #2 tuning #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
happycube wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Issue #2 tuning #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cxadc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,8 @@ static int cxadc_probe(struct pci_dev *pci_dev,
}

/* set vbi agc */
cx_write(MO_AGC_SYNC_SLICER, 0x0);
/* Set the sample delays to maximum (issue #2) */
cx_write(MO_AGC_SYNC_SLICER, (0xff << 8) || 0xff);

if (level < 0)
level = 0;
Expand All @@ -653,6 +654,9 @@ static int cxadc_probe(struct pci_dev *pci_dev,
/* set gain of agc but not offset */
cx_write(MO_AGC_GAIN_ADJ3, (0x28<<16)|(0x28<<8)|(0x50<<0));

/* Disable PLL adjust (stabilizes output when video is detected by chip) */
cx_write(MO_PLL_ADJ_CTRL, cx_read(MO_PLL_ADJ_CTRL) & ~(0x0<<25));
Copy link
Contributor

@ali1234 ali1234 Mar 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line doesn't alter the value of MO_PLL_ADJ_CTRL. It should be ~(0x1<<25) to set PLL_ADJ_EN to 0.


if (audsel != -1) {
/*
* Pixelview PlayTVPro Ultracard specific
Expand Down