refactor(core): streamline the correspondence engine loop#114
Merged
Conversation
…e helper Split run_inner's two large post-loop blocks into build_edit_lists and compact_edit_lists, and collapse the repeated fire-counter/FireEvent bookkeeping into RunStats::record_fire. Pure mechanical extraction; behavior unchanged (core + vector suites green).
Replace the positional (u8, u32, ArtifactFormat[, String]) parse/decline memoization tuples with named ParseClaim/Decline structs (+ side_code and ParseClaim::declined_by helpers), and collapse the three duplicated LinkCtx constructions into a single link_ctx() helper. Behavior unchanged (core + vector suites green; clippy clean).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainability refactor of
binoc-core's correspondence driver — no behavior change.record_firehelper out of the main loop.LinkCtxconstruction.Touches only
binoc-core/src/correspondence/driver.rs.just checkand the fulljust testsuite pass.(Auto generated pull request)