Change the Way Width is Determined #1439
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For jQuery, we first test the css('width') of a select. This always
returns a value for visible selects, but it will return false
for hidden selects with no style set (inline or class based).
For Prototype, we first check the getStyle('width') of a select. This
behaves much the same way as jQuery's css('width'), fortunately.
fields width gets set to "-10px". So let's make sure there's a value!
This solves an issue with jQuery's `outerWidth` method which breaks on hidden objects with a % width in their style. offsetWidth simply returns a 0 on those objects which suits our purpose just fine.
This was referenced Aug 1, 2013
| return if @options.width? then @options.width else "#{@form_field.offsetWidth}px" | ||
| return @options.width if @options.width? | ||
|
|
||
| if jQuery? and $ is jQuery |
There was a problem hiding this comment.
I don't think we should have jquery-specific code in AbstractChosen. The method should be moved to the different Chosen implementations
|
Is anyone currently looking into these width issue (the one that occurs when select is hidden)? I did try these fixes that @pfiller pushed here but these haven't solved the problem for me. |
This was referenced Sep 20, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@harvesthq/chosen-developers
This fixes some issues that come when applying Chosen to a
selectthat is not visible (when you haven't setwidth: nfor whatever reason). Basically, it uses jQuery & Prototypes magic methods for getting width if they're set and falls back tooffsetWidthif they're not. As always, a width specified in the option object will take precedence.I went a little crazy testing this. Each of these fiddles demonstrates 4 ways you would apply width to Chosen in both a container that is hidden on page load and a container that is visible on page load. As you can see, with the exception of a hidden select that has no style applied to it, the new version does a wonderful job of matching size:
Please Note: This doesn't fix the % width issue (people will still need to specify those via
width: %. I only mention this because one of these examples uses a percentage width set via a class. If you adjust the width of the output area, Chosen might not match it's original field. The best thing to do is adjust the width of the area and then click "Run" again. (Can you tell I learned this the hard way?)