Passes some useful outputs to root module #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omkensey
suggested changes
Sep 23, 2022
Contributor
omkensey
left a comment
omkensey
left a comment
There was a problem hiding this comment.
Minor nit -- for consistency, can you change ip to ips on the outputs formatted as splat expressions?
omkensey
reviewed
Nov 28, 2022
Comment on lines
+13
to
+19
| output "controller_instance_ip" { | ||
| value = aws_instance.controller.*.public_ip | ||
| } | ||
|
|
||
| output "worker_instance_ip" { | ||
| value = aws_instance.worker.*.public_ip | ||
| } |
Contributor
There was a problem hiding this comment.
Let's name these ips rather than ip as well since it looks like they'll come out as lists.
omkensey
suggested changes
Nov 28, 2022
Comment on lines
+13
to
+15
| output "worker_ips" { | ||
| value = module.aws.worker_instance_ip | ||
| } |
Contributor
There was a problem hiding this comment.
I think this needs to be splatified like the one before it since the underlying output is a list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.