Skip to content

Passes some useful outputs to root module #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nickwales wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Passes some useful outputs to root module #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1352a54
Passes some useful outputs to root module
nickwales Sep 22, 2022
219b1f2
Updates "ip" to "ips"
nickwales Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions deployment/aws/aws/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,11 @@ output "target_ips" {
output "kms_recovery_key_id" {
value = aws_kms_key.recovery.id
}

output "controller_instance_ip" {
value = aws_instance.controller.*.public_ip
}

output "worker_instance_ip" {
value = aws_instance.worker.*.public_ip
}
Comment on lines +13 to +19
Copy link
Contributor

@omkensey omkensey Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's name these ips rather than ip as well since it looks like they'll come out as lists.

15 changes: 15 additions & 0 deletions deployment/aws/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
output "boundary_lb" {
value = module.aws.boundary_lb
}

output "target_ips" {
value = module.aws.target_ips
}

output "controller_ips" {
value = module.aws.controller_instance_ip.*
}

output "worker_ips" {
value = module.aws.worker_instance_ip
}
Comment on lines +13 to +15
Copy link
Contributor

@omkensey omkensey Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be splatified like the one before it since the underlying output is a list.