Stop rdp process on logout #3078
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: 🎸 added a new RDP service * fix: 🐛 rdp test * refactor: 💡 update error handling for fetching rdp clients * refactor: 💡 addressed comments * fix: 🐛 revert private field * refactor: 💡 addressed comments * refactor: 💡 updated rdp clients to array of strings
* feat: 🎸 preferred clients section on settings page * chore: 🤖 update mock ipc with new handlers * refactor: 💡 moved windows rdp protocol to const * refactor: 💡 moved rdp calls to app route * test: 💍 fixed failings tests * refactor: 💡 addressed comments * fix: 🐛 fixed failing tests * refactor: 💡 add mock rdp service calls to tests * refactor: 💡 addressed comments * test: 💍 add additional tests * refactor: 💡 fixed test failure
* feat: 🎸 preferred clients section on settings page * refactor: 💡 moved rdp calls to app route * test: 💍 fixed failings tests * refactor: 💡 addressed comments * fix: 🐛 fixed failing tests * refactor: 💡 add mock rdp service calls to tests * feat: 🎸 adds open button to session details page * fix: 🐛 translation string * refactor: 💡 address feedback * refactor: 💡 address comment * fix: 🐛 test failure
* test: 💍 e2e test for rdp client launch * test: 💍 added rdp test helper * refactor: 💡 misc * refactor: 💡 addressed comments * refactor: 💡 removed similar test
* refactor: 💡 updated logic to store preferred rdp client * refactor: 💡 simplified preferred client logic
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ZedLi
reviewed
Nov 18, 2025
| handle('stopAll', async () => sessionManager.stopAll()); | ||
| handle('stopAll', async () => { | ||
| await sessionManager.stopAll(); | ||
| rdpClientManager.stopAll(); |
Collaborator
There was a problem hiding this comment.
Is the other stopAll still needed if it's added here? Also not sure if it's just my environment but it seems like this doesn't quit the mstsc app, is that the same for you?
DhariniJeeva
force-pushed
the
llb/rdp-client-launch
branch
from
3c763ed to
4fc3244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr stops rdp processes on logout.
Screenshots (if appropriate)
How to Test
Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.