Backport of fix: use net.JoinHostPort for remaining Envoy admin URLs into release/1.8.x#1069
Open
hc-github-team-consul-core wants to merge 1 commit intorelease/1.8.xfrom
Conversation
github-team-consul-core-pr-approver
approved these changes
Apr 28, 2026
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #1066 to be assessed for backporting due to the inclusion of the label backport/1.8.
The below text is copied from the body of the original PR.
Description
Follow-up to #1064.
This updates the remaining Envoy admin URLs in
pkg/envoy/proxy.goto usenet.JoinHostPortinstead of manually formattinghost:portpairs.The previous
fmt.Sprintf("http://%s:%v/...")pattern is not safe for all admin bind addresses, especially IPv6 addresses.Drain()andQuit()were already updated to usenet.JoinHostPort; this change applies the same fix to:DumpConfig()via/config_dump?include_edsReady()via/readyThis keeps Envoy admin endpoint construction consistent across the proxy manager and avoids malformed URLs when the admin address is not a simple IPv4/hostname value.
Testing
pkg/envoy/proxy_test.goOverview of commits