Update Radio and Checkbox font weight in the Dropdown #2854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
In testing some ways to extend the
Dropdownto supportAdvanced Tablefeatures it was discovered that the checkbox and radio list items used a different font weight from the rest of the list items.This PR:
Hds::Text::Bodysimilarly to the other list item componentsmediumcountto useHds::Text::Bodyin radio and checkbox to match the implementation in the checkmark.📸 Screenshots
Checkbox
Before:
After:
Radio
Before:
After:
🔗 External links
Jira ticket: HDS-4837
Figma file: Branch
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.