Skip to content

Update Radio and Checkbox font weight in the Dropdown #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 6, 2025
Merged

Update Radio and Checkbox font weight in the Dropdown #2854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
01b081b
Replaced spans with Hds::Text and set correct font weight
jorytindall May 3, 2025
45e8f59
Update formatting and cleanup
jorytindall May 5, 2025
ea8fadc
lint
jorytindall May 5, 2025
294dfa8
Remove test from showcase
jorytindall May 5, 2025
e181069
Changeset
jorytindall May 5, 2025
74d145b
Revert formatting indent
jorytindall May 5, 2025
fb734c8
Cleanup changeset entry
jorytindall May 5, 2025
d00a053
Lint showcase
jorytindall May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/rude-rice-hang.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@hashicorp/design-system-components": patch
---

`Dropdown` - Updated Radio and Checkbox list items font weight to match other
list items.
14 changes: 12 additions & 2 deletions packages/components/src/components/hds/dropdown/list-item/checkbox.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,19 @@
<Hds::Icon @name={{@icon}} />
</span>
{{/if}}
<span class="hds-dropdown-list-item__text-content">{{yield}}</span>
<Hds::Text::Body
@tag="span"
@size="200"
@weight="medium"
class="hds-dropdown-list-item__text-content"
>{{yield}}</Hds::Text::Body>
{{#if @count}}
<span class="hds-dropdown-list-item__count hds-typography-body-100 hds-font-weight-medium">{{@count}}</span>
<Hds::Text::Body
@tag="span"
@size="100"
@weight="medium"
class="hds-dropdown-list-item__count"
>{{@count}}</Hds::Text::Body>
{{/if}}
</label>
</li>
9 changes: 6 additions & 3 deletions packages/components/src/components/hds/dropdown/list-item/checkmark.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,12 @@
<Hds::Icon @name={{@icon}} />
</span>
{{/if}}
<Hds::Text::Body @tag="span" @size="200" @weight="medium" class="hds-dropdown-list-item__interactive-text">
{{yield}}
</Hds::Text::Body>
<Hds::Text::Body
@tag="span"
@size="200"
@weight="medium"
class="hds-dropdown-list-item__interactive-text"
>{{yield}}</Hds::Text::Body>
{{#if @count}}
<Hds::Text::Body
class="hds-dropdown-list-item__count"
Expand Down
10 changes: 7 additions & 3 deletions packages/components/src/components/hds/dropdown/list-item/radio.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,18 @@
<Hds::Icon @name={{@icon}} />
</div>
{{/if}}
<span class="hds-dropdown-list-item__text-content">{{yield}}</span>

<Hds::Text::Body
@tag="span"
@size="200"
@weight="medium"
class="hds-dropdown-list-item__text-content"
>{{yield}}</Hds::Text::Body>
{{#if @count}}
<Hds::Text::Body
class="hds-dropdown-list-item__count"
@tag="span"
@size="100"
@weight="medium"
class="hds-dropdown-list-item__count"
>{{@count}}</Hds::Text::Body>
{{/if}}
</label>
Expand Down
6 changes: 4 additions & 2 deletions showcase/app/templates/components/dropdown.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,8 @@
<SFI.Label>With
<code>@href</code>
⇒
<code>&lt;a&gt;</code></SFI.Label>
<code>&lt;a&gt;</code>
</SFI.Label>
<div class="hds-dropdown__content">
<ul class="hds-dropdown__list">
<Hds::Dropdown::ListItem::Interactive @href="/">
Expand All @@ -536,7 +537,8 @@
⇒
<code>&lt;LinkTo&gt;</code>
⇒
<code>&lt;a&gt;</code></SFI.Label>
<code>&lt;a&gt;</code>
</SFI.Label>
<div class="hds-dropdown__content">
<ul class="hds-dropdown__list">
<Hds::Dropdown::ListItem::Interactive @route="components.dropdown">
Expand Down