Skip to content

Showcase - Add a frameless example for the AppSideNav #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

didoo
Copy link
Contributor

@didoo didoo commented May 14, 2025

📌 Summary

Small PR that adds a demo "frameless" example to the AppSideNav showcase page (noticed while reviewing #2869). In the process, I have also removes some old/dead code (it was commented out).


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

@didoo didoo requested a review from a team as a code owner May 14, 2025 20:22
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 14, 2025 8:23pm
hds-website ✅ Ready (Inspect) Visit Preview May 14, 2025 8:23pm

@didoo didoo requested a review from shleewhite May 14, 2025 20:22
@didoo
Copy link
Contributor Author

didoo commented May 14, 2025

@shleewhite another small PR, if you have 1 min

@didoo didoo merged commit 85ebe9c into main May 14, 2025
17 checks passed
@didoo didoo deleted the showcase-app-side-nav-add-frameless-example branch May 14, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants