Time
- fix type error where TooltipButton
text could be undefined
#2877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would resolve a type error where the
TooltipButton
text could be undefined. Opted to just return''
if the date is invalid or if it cannot be converted into a UTC ISO format because other functions likerangeIsoUtcString
and thehds-format-time
helper return an empty string if it is invalid.Other options considered
TooltipButton
to let thetext
argument be optional: not used because this would have much larger consequences and we'd rather ensure tooltips always have text.🔗 External links
Jira ticket: HDS-4517
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.