Skip to content

Time - fix type error where TooltipButton text could be undefined #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

Time - fix type error where TooltipButton text could be undefined #2877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b9cb44
fix: return empty string if invalid date for tooltip text
May 14, 2025
0a20e12
chore: changeset
May 14, 2025
f6377ee
chore: lint
May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/itchy-ravens-shout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hashicorp/design-system-components": patch
---

`Time` - fixed type error where the TooltipButton text could be undefined.
1 change: 0 additions & 1 deletion packages/components/src/components/hds/time/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
{{~#if this.hasTooltip~}}
<Hds::TooltipButton
class="hds-time-wrapper"
{{! @glint-expect-error: FIXME: pnpm migration }}
@text={{if
display.options.tooltipFormat
(hds-format-date this.date display.options.tooltipFormat)
Expand Down
8 changes: 5 additions & 3 deletions packages/components/src/components/hds/time/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,16 @@ export default class HdsTime extends Component<HdsTimeSignature> {
return this.args.hasTooltip ?? true;
}

get isoUtcString(): string | undefined {
get isoUtcString(): string {
const date = this.date;

if (dateIsValid(date)) {
return this.hdsTime.toIsoUtcString(date);
const isoUtcString = this.hdsTime.toIsoUtcString(date);

if (isoUtcString) return isoUtcString;
}

return undefined;
return '';
}

get rangeIsoUtcString(): string {
Expand Down