[WIP-00] [Project Solar / Phase 1] Main feature branch to add modes support to tokens + components + showcase #3237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
didoo
changed the title
7 tasks
didoo
changed the title
didoo
changed the title
didoo
force-pushed
the
project-solar/phase-1-main-feature-branch
branch
from
519a6a6 to
3863dfa
Compare
didoo
changed the title
didoo
force-pushed
the
project-solar/phase-1-main-feature-branch
branch
from
3863dfa to
a88accd
Compare
didoo
force-pushed
the
project-solar/phase-1-main-feature-branch
branch
from
a88accd to
5375e7a
Compare
didoo
force-pushed
the
project-solar/phase-1-main-feature-branch
branch
from
5375e7a to
6f015ce
Compare
didoo
force-pushed
the
project-solar/phase-1-main-feature-branch
branch
from
6f015ce to
20d4838
Compare
…added custom source files for theming + updated rollup config to process different files
…th output from `rollup-plugin-scss`
…er-cli-build.js`
… to new custom plugin
…ugin for every Scss compilation)
…validate that all the new CSS files are generated too
… for old CSS files that don’t exist anymore)
…tion, per code review suggestion #3259 (comment)
Co-authored-by: Copilot <[email protected]>
…ents.scss Co-authored-by: Kristin Bradley <[email protected]>
…6_modes/modes-pipeline-implementation [02] [Project Solar / Phase 1 / Tokens Pipeline] Add `$modes` support to tokens pipeline
…5_components/modes-css-compilation [03] [Project Solar / Phase 1 / Themed CSS for HDS components] Rollup configuration and Sass processing for multiple files
…6_modes/modes-feature-branch [01] [Project Solar / Phase 1 / Tokens Pipeline] Main feature branch for `$modes` support in tokens pipeline and component's CSS compilation
didoo
force-pushed
the
project-solar/phase-1-main-feature-branch
branch
from
c1daff5 to
4d46a8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This is the main feature branch for the first part of the work needed to create a working integral flow that connects the design tokens pipeline (updated to support
$modes) to the CSS for the HDS components (updated to generate multiple CSS files in input, including themed tokens where needed) to the showcase (updated to support theme switching and the theming of HDS components for the their migration to the Carbon visual language, aka "carbonization")🛠️ Detailed description
This PR will include:
$modessupport in tokens pipeline and component's CSS compilation #3238$modessupport to tokens pipeline #3239🔗 External links
Jira ticket (Milestone): https://hashicorp.atlassian.net/browse/RDPR-830
Figma file: https://www.figma.com/design/dH5BKO7rHWGZaBuK7rRt5S/Dry-runs?node-id=376-15499&p=f&t=e583xddN1Yrqpuyr-0
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.