Skip to content

Conversation

@didoo
Copy link
Contributor

@didoo didoo commented Sep 25, 2025

📌 Summary

This is the feature branch for the work needed to add support in the design the tokens pipeline for:

  • definition of co-located $modes token values in the src JSON files
  • generation of multiple "themed" CSS files in output

It is based on top of #3237

🛠️ Detailed description

This PR includes:

🔗 External links

Jira ticket (Epic): https://hashicorp.atlassian.net/browse/HDS-5193


👀 Component checklist

  • Percy was checked for any visual regression
  • A changelog entry was added via Changesets if needed (see templates here)
    • changelogs will be added in the main feature branch

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Sep 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Nov 25, 2025 10:23pm
hds-website Ready Ready Preview Nov 25, 2025 10:23pm

@didoo didoo changed the title [WIP] Add $modes support to tokens pipeline [WIP] [Project solaris / Phase 1 / Tokens Pipeline] Add $modes support to tokens pipeline Sep 25, 2025
@didoo didoo changed the title [WIP] [Project solaris / Phase 1 / Tokens Pipeline] Add $modes support to tokens pipeline [WIP] [Project solaris / Phase 1 / Tokens Pipeline] Main feature branch for $modes support in tokens pipeline Sep 25, 2025
@didoo didoo changed the title [WIP] [Project solaris / Phase 1 / Tokens Pipeline] Main feature branch for $modes support in tokens pipeline [WIP] [Project Solar / Phase 1 / Tokens Pipeline] Main feature branch for $modes support in tokens pipeline Sep 25, 2025
@didoo didoo force-pushed the project-solar/phase-1-main-feature-branch branch from 519a6a6 to 3863dfa Compare September 30, 2025 14:50
@didoo didoo force-pushed the project-solar/phase-1/HDS-5216_modes/modes-feature-branch branch from bcb7219 to fa4bad2 Compare September 30, 2025 14:50
@didoo didoo changed the title [WIP] [Project Solar / Phase 1 / Tokens Pipeline] Main feature branch for $modes support in tokens pipeline [WIP0-01] [Project Solar / Phase 1 / Tokens Pipeline] Main feature branch for $modes support in tokens pipeline Oct 9, 2025
@didoo didoo changed the title [WIP0-01] [Project Solar / Phase 1 / Tokens Pipeline] Main feature branch for $modes support in tokens pipeline [WIP-01] [Project Solar / Phase 1 / Tokens Pipeline] Main feature branch for $modes support in tokens pipeline Oct 9, 2025
@didoo didoo changed the title [WIP-01] [Project Solar / Phase 1 / Tokens Pipeline] Main feature branch for $modes support in tokens pipeline [WIP-01] [Project Solar / Phase 1 / Tokens Pipeline] Main feature branch for $modes support in tokens pipeline and component's CSS compilation Oct 10, 2025
@didoo didoo force-pushed the project-solar/phase-1-main-feature-branch branch from 3863dfa to a88accd Compare October 10, 2025 17:19
@didoo didoo force-pushed the project-solar/phase-1/HDS-5216_modes/modes-feature-branch branch from fa4bad2 to 3a4d9f2 Compare October 10, 2025 17:19
@didoo didoo force-pushed the project-solar/phase-1-main-feature-branch branch from a88accd to 5375e7a Compare October 24, 2025 17:30
@didoo didoo force-pushed the project-solar/phase-1/HDS-5216_modes/modes-feature-branch branch from 3a4d9f2 to d7609e3 Compare October 24, 2025 17:30
@didoo didoo force-pushed the project-solar/phase-1-main-feature-branch branch from 5375e7a to 6f015ce Compare October 27, 2025 20:53
@didoo didoo force-pushed the project-solar/phase-1/HDS-5216_modes/modes-feature-branch branch from d7609e3 to 41f911f Compare October 27, 2025 20:54
@didoo didoo force-pushed the project-solar/phase-1-main-feature-branch branch from 6f015ce to 20d4838 Compare November 5, 2025 16:34
didoo and others added 18 commits November 20, 2025 09:43
…added custom source files for theming + updated rollup config to process different files
…validate that all the new CSS files are generated too
… for old CSS files that don’t exist anymore)
…6_modes/modes-pipeline-implementation

[02] [Project Solar / Phase 1 / Tokens Pipeline] Add `$modes` support to tokens pipeline
…5_components/modes-css-compilation

[03] [Project Solar / Phase 1 / Themed CSS for HDS components] Rollup configuration and Sass processing for multiple files
@didoo didoo marked this pull request as ready for review November 25, 2025 22:39
@didoo didoo requested a review from a team as a code owner November 25, 2025 22:39
@didoo didoo changed the title [WIP-01] [Project Solar / Phase 1 / Tokens Pipeline] Main feature branch for $modes support in tokens pipeline and component's CSS compilation [01] [Project Solar / Phase 1 / Tokens Pipeline] Main feature branch for $modes support in tokens pipeline and component's CSS compilation Nov 25, 2025
@didoo didoo merged commit 4d46a8b into project-solar/phase-1-main-feature-branch Nov 25, 2025
18 checks passed
@didoo didoo deleted the project-solar/phase-1/HDS-5216_modes/modes-feature-branch branch November 25, 2025 22:40
@didoo
Copy link
Contributor Author

didoo commented Nov 25, 2025

merged this PR since it was just an empty container of the two "child" PRs, nothing else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants