-
Notifications
You must be signed in to change notification settings - Fork 50
[01] [Project Solar / Phase 1 / Tokens Pipeline] Main feature branch for $modes support in tokens pipeline and component's CSS compilation
#3238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
didoo
merged 68 commits into
project-solar/phase-1-main-feature-branch
from
project-solar/phase-1/HDS-5216_modes/modes-feature-branch
Nov 25, 2025
Merged
Changes from all commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
c7bad46
TODO - added temporary file to main feature branch for phase 1
didoo 71fd7ef
added temporary changeset to feature branch for `$modes` support
didoo 69d5a5c
TEMP - added `$modes` entry to `color.palette.neutral-0`
didoo ae99955
refactored logic used to provide SD configuration per target
didoo af2f34e
progress on logic for handling `$modes` - 1
didoo c0a1e3c
TEMP - added `modes-testing` tokens
didoo 9a55689
TEMP - added `expected-CSS-output` files
didoo f0c5e94
progress on logic for handling `$modes` - 2
didoo 6cfee07
added `attributes/themeable` transformation
didoo 7cc7853
progress on logic for handling `$modes` - 3
didoo e8dc4ee
TEMP - used local version of Style Dictionary for debugging
didoo b5c4125
progress on logic for handling `$modes` - 4
didoo 4cf8fd1
TEMP generated temporary dist files for testing
didoo 2a9547f
TEMP - added examples of generated themed tokens
didoo 76e0358
added logic to generate theming CSS files
didoo abd9576
REVERT - Removed `modes-testing` tokens
didoo dc7b2ad
removed `modes-testing` folder from compilation
didoo 8ce296b
added `carbon-extracted` reference in the `source` definitions
didoo d170478
TEMP - added `$modes` entries for some color and typography tokens, w…
didoo 930f57b
changed `outputReferences` to `false` (temporary) to bypass issue wit…
didoo d891405
added commented code to `build` to use for debugging issue with missi…
didoo 39319d6
added two new themed tokens generated files, for Scss mixins and for …
didoo 4ead7dc
fixed issue with `cds` naming missing the `g`
didoo b7c4007
fixed some issues with how the “extra” themed CSS files were generated
didoo 81268fe
TEMP - Re-generated tokens
didoo b3cf42c
REVERT - used local version of Style Dictionary for debugging
didoo 4b23415
REVERT - added examples of generated themed tokens
didoo 46676c3
REVERT - added `expected-CSS-output` files
didoo 07c1b7f
fixed wrong check for existence of key in object (`0` values would tr…
didoo 30467ec
added `.hds-theme-light/dark` and `[data-hds-theme=“light/dark”]` to …
didoo f0fb471
re-generated themed tokens
didoo 507c06b
updated generation of tokens’ CSS helpers to use CSS variables for `f…
didoo d5252d4
re-generated CSS helper files
didoo 2d7deb2
updated generation of extra CSS files to include `.hds-theme-hds/[dat…
didoo 980383a
updated design tokens pipeline to generate a `themed-tokens.json` fil…
didoo 19ff901
re-generated themed tokens
didoo c1fc24e
updated “src” files to replace `hds` key with `default` in `$modes` d…
didoo 4396bb0
updated logic to replace `hds` key with `default` in `$modes` definit…
didoo abd1393
re-generated tokens in `dist` folder
didoo c382225
tweaked logic for CSS selectors for `@media (prefers-color-scheme)` t…
didoo 54be4e6
re-generated tokens in `dist` folder
didoo 32f0fcc
updated generation of extra theming CSS files to avoid CSS variables …
didoo ac1217c
updated generation of extra theming CSS files to differentiate betwee…
didoo 5039a0f
re-generated tokens in `dist` folder
didoo 5108db5
removed `[data-hds-theme]` CSS selectors for simplicity
didoo 20b962d
re-generated tokens in `dist` folder
didoo f9c268b
updated logic for generation of extra “themed” CSS files (removed `pr…
didoo 5c338f4
re-generated tokens in `dist` folder
didoo 11877e7
small tweakings before code review
didoo f8caa0f
renamed `generateExtra***` to `generate***`
didoo 9e45b40
updated comment
didoo 4e131af
Draft a custom plugin to compile the themed SCSS
alex-ju 1ced1d2
updated SCSS files organization for components (split common part) + …
didoo d416e7f
added support for source maps for generated themed CSS files
didoo 2935a3d
TEMP - Added generation of “alt” CSS for HDS components to compare wi…
didoo 423b892
abstracted logic for custom Rollup plugin to compile multiple Sass fi…
didoo aeac349
updated `includePaths` for design tokens in Showcase and Website `emb…
didoo fc45c2f
moved compilation of existing Scss files for components and overrides…
didoo 394a058
removed `rollup-plugin-scss` dev dependency (we use our own custom pl…
didoo 909e008
added CSS compilation for `combined-strategies` tokens
didoo 5c22feb
updated the `prePublish` script in `package.json` of `components` to …
didoo 24c9c9b
simplified architecture of CSS compilation for HDS components (as agr…
didoo 16f51cb
fixed `prepublisOnly` script that was causing error in build (looking…
didoo afb6e3f
updated `cssFilePath` in blueprints to reflect new Scss file organiza…
didoo 2fa10f4
Apply suggestions from code review
didoo 053e6de
Update packages/components/src/styles/@hashicorp/design-system-compon…
didoo b883034
Merge pull request #3239 from hashicorp/project-solar/phase-1/HDS-521…
didoo 1864883
Merge pull request #3259 from hashicorp/project-solar/phase-1/HDS-550…
didoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| "@hashicorp/design-system-tokens": major | ||
| --- | ||
|
|
||
| MODES - TODOs | ||
|
|
||
| - Decide if this is a `major` or a `minor` | ||
| - Add a proper changeset entry here | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| DELETE ME! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
packages/components/src/styles/@hashicorp/design-system-components-common.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| /** | ||
| * Copyright (c) HashiCorp, Inc. | ||
| * SPDX-License-Identifier: MPL-2.0 | ||
| */ | ||
|
|
||
| // these files come from `packages/tokens/dist/` | ||
| @use "products/css/helpers/color"; | ||
| @use "products/css/helpers/elevation"; | ||
| @use "products/css/helpers/focus-ring"; | ||
| @use "products/css/helpers/typography"; | ||
|
|
||
| // main components file | ||
| @use "../components/index"; | ||
|
|
||
| // screen-reader utility class | ||
| @use "../mixins/screen-reader-only" as *; | ||
|
|
||
| // The `.sr-only` utility class visually hides content but keeps it accessible to screen readers for accessibility purposes. | ||
| .sr-only { | ||
| @include screen-reader-only(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /** | ||
| * Copyright (c) HashiCorp, Inc. | ||
| * SPDX-License-Identifier: MPL-2.0 | ||
| */ | ||
|
|
||
| // Notice: this list can be automatically edited by the Ember blueprint, please don't remove the start/end comments | ||
| // START COMPONENTS CSS FILES IMPORTS | ||
| @use "./accordion"; | ||
| @use "./advanced-table"; | ||
| @use "./alert"; | ||
| @use "./app-footer"; | ||
| @use "./app-frame"; | ||
| @use "./app-header"; | ||
| @use "./app-side-nav"; | ||
| @use "./application-state"; | ||
| @use "./badge"; | ||
| @use "./badge-count"; | ||
| @use "./breadcrumb"; | ||
| @use "./button"; | ||
| @use "./button-set"; | ||
| @use "./card"; | ||
| @use "./code-block"; | ||
| @use "./code-editor"; | ||
| @use "./copy"; | ||
| @use "./dialog-primitive"; | ||
| @use "./disclosure-primitive"; | ||
| @use "./dismiss-button"; | ||
| @use "./dropdown"; | ||
| @use "./flyout"; | ||
| @use "./form"; // multiple components | ||
| @use "./icon"; | ||
| @use "./icon-tile"; | ||
| @use "./layout"; // multiple components | ||
| @use "./link"; // multiple components | ||
| @use "./menu-primitive"; | ||
| @use "./modal"; | ||
| @use "./page-header"; | ||
| @use "./pagination"; | ||
| @use "./reveal"; | ||
| @use "./rich-tooltip"; | ||
| @use "./segmented-group"; | ||
| @use "./separator"; | ||
| @use "./side-nav"; | ||
| @use "./stepper"; | ||
| @use "./table"; | ||
| @use "./tabs"; | ||
| @use "./tag"; | ||
| @use "./text"; | ||
| @use "./time"; | ||
| @use "./toast"; | ||
| @use "./tooltip"; | ||
| // END COMPONENT CSS FILES IMPORTS |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.