[Project Solar / Phase 1 / Engineering Follow-ups] Fix logic to extract Carbon animation easing tokens #3398
+56
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mat to use always seconds
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the format of Carbon motion tokens to align with DTCG (Design Tokens Community Group) specifications. The changes ensure consistent representation of animation easing functions and durations across the design system.
Key changes:
- Converted cubic-bezier type from
cubic-beziertocubicBezierand transformed values from CSS function format to array format - Standardized all duration values to use seconds instead of milliseconds
- Re-extracted Carbon tokens with the updated conversion logic
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/tokens/src/carbon-extracted/motion/easings.json | Updated easing token types and values to DTCG-compliant format |
| packages/tokens/src/carbon-extracted/motion/durations.json | Converted duration values from milliseconds to seconds |
| packages/tokens/scripts/extract-carbon-parts/convertObjectToDtcgFormat.ts | Added conversion logic for cubic-bezier and duration standardization |
packages/tokens/scripts/extract-carbon-parts/convertObjectToDtcgFormat.ts
Show resolved
Hide resolved
|
|
||
| function convertCubicBezierValue(value: string) { | ||
| // eg. `cubic-bezier(0.2, 0, 0.38, 0.9)` | ||
| const match = value.match(/^cubic-bezier\((.*)\)$/); |
Contributor
There was a problem hiding this comment.
This seems a bit broad in what it matches in the parenthesis, but I don't know if that's a real concern.
KristinLBradley
approved these changes
Dec 3, 2025
Contributor
KristinLBradley
left a comment
KristinLBradley
left a comment
There was a problem hiding this comment.
Looks good to me. I just added one minor question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Small PR that fixes some format inconsistencies for the "motion" Carbon tokens
🛠️ Detailed description
In this PR I have:
cubic-beziervalue to the expected DTCG formatsrcfiles🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-5671
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.