Skip to content

[Project Solar / Phase 1 / Engineering Follow-ups] Fix logic to extract Carbon animation easing tokens #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: project-solar/phase-1-main-feature-branch
Choose a base branch
from
+56 −35
Open

[Project Solar / Phase 1 / Engineering Follow-ups] Fix logic to extract Carbon animation easing tokens #3398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d4f3b6
updated logic that converts the Carbon duration value to the DTCG for…
didoo Dec 2, 2025
69697b5
updated logic that converts the Carbon `cubic-bezier` value to the ex…
didoo Dec 2, 2025
583d2a7
re-extracted carbon tokens
didoo Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 32 additions & 11 deletions packages/tokens/scripts/extract-carbon-parts/convertObjectToDtcgFormat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,20 @@ function recursivelyProcessObject({ key, value, type, group}: Args): CarbonDesig
'cds-original-value': value
};
case 'cubic-bezier':
return {
// TODO convert to `cubicBezier` per DTCG specifications when we are sure that Style Dictionary process it correctly
// see: https://www.designtokens.org/tr/drafts/format/#cubic-bezier
'$type': 'cubic-bezier',
'$value': value,
'group': group || 'cds-generic-cubic-bezier',
'private': true,
'cds-original-value': value
};
const convertedCubicBezierValue = convertCubicBezierValue(value);
if (convertedCubicBezierValue !== undefined) {
return {
// see: https://www.designtokens.org/tr/drafts/format/#cubic-bezier
'$type': 'cubicBezier',
'$value': convertedCubicBezierValue.$value,
'group': group || 'cds-generic-cubic-bezier',
'private': true,
'cds-original-value': value
};
} else {
const unknownCubicBezierToken = returnUnknownToken(value, `🚨 convertCubicBezierValue: value for key "${key}" / group "${group}" is not in the expected format:`);
return unknownCubicBezierToken;
}
case 'duration':
const convertedDurationValue = convertDurationValue(value);
if (convertedDurationValue !== undefined) {
Expand Down Expand Up @@ -157,11 +162,27 @@ function recursivelyProcessObject({ key, value, type, group}: Args): CarbonDesig
}
}

function convertCubicBezierValue(value: string) {
// eg. `cubic-bezier(0.2, 0, 0.38, 0.9)`
const match = value.match(/^cubic-bezier\((.*)\)$/);
Copy link
Contributor

@KristinLBradley KristinLBradley Dec 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit broad in what it matches in the parenthesis, but I don't know if that's a real concern.

if (match) {
const $value = `[${match[1]}]`;
return { $value };
} else {
return undefined;
}
}

function convertDurationValue(value: string) {
const match = value.match(/^(\d+)(s|ms)$/);
if (match) {
const $value = Number(match[1]);
const unit = match[2];
let $value = Number(match[1]);
let unit = match[2];
// we want to standardize the unit to "seconds"
if (unit === 'ms') {
$value = $value / 1000;
unit = 's';
}
return { $value, unit };
} else {
return undefined;
Expand Down
24 changes: 12 additions & 12 deletions packages/tokens/src/carbon-extracted/motion/durations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@
"slow": {
"01": {
"$type": "duration",
"$value": 400,
"unit": "ms",
"$value": 0.4,
"unit": "s",
"group": "cds-motion",
"private": true,
"cds-original-value": "400ms"
},
"02": {
"$type": "duration",
"$value": 700,
"unit": "ms",
"$value": 0.7,
"unit": "s",
"group": "cds-motion",
"private": true,
"cds-original-value": "700ms"
Expand All @@ -23,16 +23,16 @@
"moderate": {
"01": {
"$type": "duration",
"$value": 150,
"unit": "ms",
"$value": 0.15,
"unit": "s",
"group": "cds-motion",
"private": true,
"cds-original-value": "150ms"
},
"02": {
"$type": "duration",
"$value": 240,
"unit": "ms",
"$value": 0.24,
"unit": "s",
"group": "cds-motion",
"private": true,
"cds-original-value": "240ms"
Expand All @@ -41,16 +41,16 @@
"fast": {
"01": {
"$type": "duration",
"$value": 70,
"unit": "ms",
"$value": 0.07,
"unit": "s",
"group": "cds-motion",
"private": true,
"cds-original-value": "70ms"
},
"02": {
"$type": "duration",
"$value": 110,
"unit": "ms",
"$value": 0.11,
"unit": "s",
"group": "cds-motion",
"private": true,
"cds-original-value": "110ms"
Expand Down
24 changes: 12 additions & 12 deletions packages/tokens/src/carbon-extracted/motion/easings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,47 +4,47 @@
"easing": {
"standard": {
"productive": {
"$type": "cubic-bezier",
"$value": "cubic-bezier(0.2, 0, 0.38, 0.9)",
"$type": "cubicBezier",
"$value": "[0.2, 0, 0.38, 0.9]",
"group": "cds-motion",
"private": true,
"cds-original-value": "cubic-bezier(0.2, 0, 0.38, 0.9)"
},
"expressive": {
"$type": "cubic-bezier",
"$value": "cubic-bezier(0.4, 0.14, 0.3, 1)",
"$type": "cubicBezier",
"$value": "[0.4, 0.14, 0.3, 1]",
"group": "cds-motion",
"private": true,
"cds-original-value": "cubic-bezier(0.4, 0.14, 0.3, 1)"
}
},
"entrance": {
"productive": {
"$type": "cubic-bezier",
"$value": "cubic-bezier(0, 0, 0.38, 0.9)",
"$type": "cubicBezier",
"$value": "[0, 0, 0.38, 0.9]",
"group": "cds-motion",
"private": true,
"cds-original-value": "cubic-bezier(0, 0, 0.38, 0.9)"
},
"expressive": {
"$type": "cubic-bezier",
"$value": "cubic-bezier(0, 0, 0.3, 1)",
"$type": "cubicBezier",
"$value": "[0, 0, 0.3, 1]",
"group": "cds-motion",
"private": true,
"cds-original-value": "cubic-bezier(0, 0, 0.3, 1)"
}
},
"exit": {
"productive": {
"$type": "cubic-bezier",
"$value": "cubic-bezier(0.2, 0, 1, 0.9)",
"$type": "cubicBezier",
"$value": "[0.2, 0, 1, 0.9]",
"group": "cds-motion",
"private": true,
"cds-original-value": "cubic-bezier(0.2, 0, 1, 0.9)"
},
"expressive": {
"$type": "cubic-bezier",
"$value": "cubic-bezier(0.4, 0.14, 1, 1)",
"$type": "cubicBezier",
"$value": "[0.4, 0.14, 1, 1]",
"group": "cds-motion",
"private": true,
"cds-original-value": "cubic-bezier(0.4, 0.14, 1, 1)"
Expand Down