Skip to content

Conversation

@yugalarora
Copy link
Contributor

@yugalarora yugalarora commented Jun 5, 2025

Description

I've added support for disabling legacy IMDS endpoints in the OCI builder.

This introduces a new boolean option, instance_options_are_legacy_imds_endpoints_disabled, to the OCI builder configuration.

When you set this to true, the launched OCI instance will be configured to disable the legacy IMDSv1 endpoints. This enhances security by enforcing the use of IMDSv2.

Resolved Issues

If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged:

Closes [#69 ]

Rollback Plan

If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

N/A

@yugalarora yugalarora requested a review from a team as a code owner June 5, 2025 08:41
@shivanshsinghraghuvanshi

Can we please get it reviewed

@yugalarora yugalarora changed the title I've added support for disabling legacy IMDS endpoints in the OCI builder Support for disabling legacy IMDS endpoints in the OCI builder Jun 5, 2025
@anshulsharma-hashicorp
Copy link

Can we please get it reviewed

Could you please add unit test cases for this change also generate check is breaking. please run make generate command and add the generated code as well in the same PR.

@anshulsharma-hashicorp
Copy link

Can we please get it reviewed

Could you please add unit test cases for this change also generate check is breaking. please run make generate command and add the generated code as well in the same PR.

Also please check this PR https://github.com/hashicorp/packer-plugin-oracle/pull/134/files for ref, if this looks okay we can go ahead with this, just let me know.

@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented Jun 11, 2025

CLA assistant check
All committers have signed the CLA.

@yugalarora
Copy link
Contributor Author

@anshulsharma-hashicorp Done, please check now.

@yugalarora yugalarora force-pushed the feature/oci-disable-legacy-imds branch from f1f781f to 637d585 Compare June 11, 2025 18:18
@anshulsharma-hashicorp
Copy link

@anshulsharma-hashicorp Done, please check now.

Hey please sign the CLA

@anshulsharma-hashicorp
Copy link

Also please check the formatting of the file in your mock file, please check the imports as lint check is breaking.

Copy link

@anshulsharma-hashicorp anshulsharma-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshulsharma-hashicorp anshulsharma-hashicorp merged commit 3e8fca2 into hashicorp:main Jun 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants