Support for disabling legacy IMDS endpoints in the OCI builder #137
Conversation
|
Can we please get it reviewed |
yugalarora
changed the title
Could you please add unit test cases for this change also generate check is breaking. please run make generate command and add the generated code as well in the same PR. |
Also please check this PR https://github.com/hashicorp/packer-plugin-oracle/pull/134/files for ref, if this looks okay we can go ahead with this, just let me know. |
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
|
@anshulsharma-hashicorp Done, please check now. |
yugalarora
force-pushed
the
feature/oci-disable-legacy-imds
branch
from
f1f781f to
637d585
Compare
Hey please sign the CLA |
| config := state.Get("config").(*Config) | ||
| config.InstanceOptionsAreLegacyImdsEndpointsDisabled = value | ||
|
|
||
| // Re-prepare the config to ensure LaunchInstanceDetails is updated |
There was a problem hiding this comment.
Please remove this comment, not a good place to add details.
|
Also please check the formatting of the file in your mock file, please check the imports as lint check is breaking. |
Description
I've added support for disabling legacy IMDS endpoints in the OCI builder.
This introduces a new boolean option,
instance_options_are_legacy_imds_endpoints_disabled, to the OCI builder configuration.When you set this to true, the launched OCI instance will be configured to disable the legacy IMDSv1 endpoints. This enhances security by enforcing the use of IMDSv2.
Resolved Issues
If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged:
Closes [#69 ]
Rollback Plan
If a change needs to be reverted, we will roll out an update to the code within 7 days.
Changes to Security Controls
N/A