-
Notifications
You must be signed in to change notification settings - Fork 15
Support for disabling legacy IMDS endpoints in the OCI builder #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for disabling legacy IMDS endpoints in the OCI builder #137
Conversation
|
Can we please get it reviewed |
Could you please add unit test cases for this change also generate check is breaking. please run make generate command and add the generated code as well in the same PR. |
Also please check this PR https://github.com/hashicorp/packer-plugin-oracle/pull/134/files for ref, if this looks okay we can go ahead with this, just let me know. |
|
@anshulsharma-hashicorp Done, please check now. |
f1f781f to
637d585
Compare
Hey please sign the CLA |
|
Also please check the formatting of the file in your mock file, please check the imports as lint check is breaking. |
anshulsharma-hashicorp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
I've added support for disabling legacy IMDS endpoints in the OCI builder.
This introduces a new boolean option,
instance_options_are_legacy_imds_endpoints_disabled, to the OCI builder configuration.When you set this to true, the launched OCI instance will be configured to disable the legacy IMDSv1 endpoints. This enhances security by enforcing the use of IMDSv2.
Resolved Issues
If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged:
Closes [#69 ]
Rollback Plan
If a change needs to be reverted, we will roll out an update to the code within 7 days.
Changes to Security Controls
N/A