Skip to content

Conversation

@pdecat
Copy link
Contributor

@pdecat pdecat commented Dec 2, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

ScheduleExpression
A CRON expression in UTC specifying when AWS Backup initiates a backup job. When no CRON expression is provided, AWS Backup will use the default expression cron(0 5 ? * * *).

https://docs.aws.amazon.com/aws-backup/latest/devguide/API_BackupRuleInput.html#Backup-Type-BackupRuleInput-ScheduleExpression

Relations

Closes #23976

References

Output from Acceptance Testing

% make testacc PKG=backup TESTS=TestAccBackupPlan_no_schedule
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-backup_plan_schedule_computed 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/backup/... -v -count 1 -parallel 20 -run='TestAccBackupPlan_no_schedule'  -timeout 360m -vet=off
2025/12/02 17:36:41 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/02 17:36:41 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccBackupPlan_no_schedule
=== PAUSE TestAccBackupPlan_no_schedule
=== CONT  TestAccBackupPlan_no_schedule
--- PASS: TestAccBackupPlan_no_schedule (26.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/backup     26.787s

@pdecat pdecat requested a review from a team as a code owner December 2, 2025 16:37
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@pdecat pdecat changed the title fix: mark schedule attribute of aws_backup_plan rule computed fix: set default value of schedule attribute of aws_backup_plan rule Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/backup Issues and PRs that pertain to the backup service. size/S Managed by automation to categorize the size of a PR. labels Dec 2, 2025
@pdecat pdecat force-pushed the b-backup_plan_schedule_computed branch from 27f2115 to f93fb3b Compare December 2, 2025 16:38
@github-actions github-actions bot added the size/M Managed by automation to categorize the size of a PR. label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-triage Waiting for first response or review from a maintainer. service/backup Issues and PRs that pertain to the backup service. size/M Managed by automation to categorize the size of a PR. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Idempotency problem with schedule on aws_backup_plan

1 participant