Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/45355.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_backup_plan: Set default value of schedule attribute of rule
```
2 changes: 2 additions & 0 deletions internal/service/backup/plan.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
)

const (
defaultPlanRuleScheduleExpression = "cron(0 5 ? * * *)"
defaultPlanRuleScheduleExpressionTimezone = "Etc/UTC"
)

Expand Down Expand Up @@ -167,6 +168,7 @@ func resourcePlan() *schema.Resource {
names.AttrSchedule: {
Type: schema.TypeString,
Optional: true,
Default: defaultPlanRuleScheduleExpression,
},
"schedule_expression_timezone": {
Type: schema.TypeString,
Expand Down
56 changes: 56 additions & 0 deletions internal/service/backup/plan_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,45 @@ func TestAccBackupPlan_basic(t *testing.T) {
})
}

func TestAccBackupPlan_no_schedule(t *testing.T) {
ctx := acctest.Context(t)
var plan backup.GetBackupPlanOutput
resourceName := "aws_backup_plan.test"
rName := fmt.Sprintf("tf-testacc-backup-%s", sdkacctest.RandString(14))

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(ctx, t); testAccPreCheck(ctx, t) },
ErrorCheck: acctest.ErrorCheck(t, names.BackupServiceID),
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
CheckDestroy: testAccCheckPlanDestroy(ctx),
Steps: []resource.TestStep{
{
Config: testAccPlanConfig_no_schedule(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckPlanExists(ctx, resourceName, &plan),
acctest.MatchResourceAttrRegionalARN(ctx, resourceName, names.AttrARN, "backup", regexache.MustCompile(`backup-plan:.+`)),
resource.TestCheckResourceAttr(resourceName, names.AttrName, rName),
resource.TestCheckResourceAttr(resourceName, acctest.CtRulePound, "1"),
resource.TestCheckTypeSetElemNestedAttrs(resourceName, "rule.*", map[string]string{
"rule_name": rName,
"target_vault_name": rName,
names.AttrSchedule: "cron(0 5 ? * * *)",
"schedule_expression_timezone": "Etc/UTC",
"lifecycle.#": "0",
}),
resource.TestCheckResourceAttr(resourceName, acctest.CtTagsPercent, "0"),
resource.TestCheckResourceAttrSet(resourceName, names.AttrVersion),
),
},
{
ResourceName: resourceName,
ImportState: true,
ImportStateVerify: true,
},
},
})
}

func TestAccBackupPlan_disappears(t *testing.T) {
ctx := acctest.Context(t)
var plan backup.GetBackupPlanOutput
Expand Down Expand Up @@ -798,6 +837,23 @@ resource "aws_backup_plan" "test" {
`, rName)
}

func testAccPlanConfig_no_schedule(rName string) string {
return fmt.Sprintf(`
resource "aws_backup_vault" "test" {
name = %[1]q
}

resource "aws_backup_plan" "test" {
name = %[1]q

rule {
rule_name = %[1]q
target_vault_name = aws_backup_vault.test.name
}
}
`, rName)
}

func testAccPlanConfig_optInToArchiveForSupportedResources(rName string) string {
return fmt.Sprintf(`
resource "aws_backup_vault" "test" {
Expand Down
Loading