azurerm_api_management_logger: added a new acceptance testcase TestAccApiManagementLogger_switch#31645
Closed
azurerm_api_management_logger: added a new acceptance testcase TestAccApiManagementLogger_switch#31645
Conversation
15 tasks
1d18394 to
e37951e
Compare
Contributor
|
This PR is being labeled as "stale" because it has not been updated for 30 or more days. If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone. If you need some help completing this PR, please leave a comment letting us know. Thank you! |
Collaborator
|
Hi @rigalGit - We don't usually add tests that require resource recreation except in very specific circumstances (e.g. a conditional ForceNew that is triggered by a CustomizeDiff, where we're testing the CustomizeDiff logic) Because of this, I'm going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
added acceptance testcase TestAccApiManagementLogger_switch to test the scenario where switching logger type between application_insights and eventhub should cause resource to be recreated.
Prior context : #31537 fixes config for TestAccApiManagementLogger_update testcase with fields which can be updated. So loggerType filed was removed from this PR as this is a replace scenario and not update one.
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Testing
This is a (please select all that apply):
AI Assistance Disclosure
Used copilot to generate testcase
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.