Skip to content

azurerm_api_management_logger: added a new acceptance testcase TestAccApiManagementLogger_switch#31645

Closed
rigalGit wants to merge 4 commits intomainfrom
jitendra/TestAccApiManagementLogger_switch
Closed

azurerm_api_management_logger: added a new acceptance testcase TestAccApiManagementLogger_switch#31645
rigalGit wants to merge 4 commits intomainfrom
jitendra/TestAccApiManagementLogger_switch

Conversation

@rigalGit
Copy link
Copy Markdown
Contributor

@rigalGit rigalGit commented Feb 2, 2026

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

added acceptance testcase TestAccApiManagementLogger_switch to test the scenario where switching logger type between application_insights and eventhub should cause resource to be recreated.

Prior context : #31537 fixes config for TestAccApiManagementLogger_update testcase with fields which can be updated. So loggerType filed was removed from this PR as this is a replace scenario and not update one.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

AI Assistance Disclosure

Used copilot to generate testcase

  • AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@rigalGit rigalGit force-pushed the jitendra/TestAccApiManagementLogger_switch branch from 1d18394 to e37951e Compare February 2, 2026 14:33
@rigalGit rigalGit changed the title Jitendra/test acc api management logger switch azurerm_api_management_logger: added a new acceptance testcase TestAccApiManagementLogger_switch Feb 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 9, 2026

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

@github-actions github-actions Bot added the stale label Mar 9, 2026
@sreallymatt
Copy link
Copy Markdown
Collaborator

Hi @rigalGit - We don't usually add tests that require resource recreation except in very specific circumstances (e.g. a conditional ForceNew that is triggered by a CustomizeDiff, where we're testing the CustomizeDiff logic)

Because of this, I'm going to close this PR.

@sreallymatt sreallymatt closed this Apr 8, 2026
@github-actions github-actions Bot removed the stale label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants