Skip to content

azurerm_api_management_logger: added a new acceptance testcase TestAccApiManagementLogger_switch #31645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rigalGit wants to merge 4 commits into from
Closed

azurerm_api_management_logger: added a new acceptance testcase TestAccApiManagementLogger_switch #31645

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64e2955
azurerm_api_management_logger: fixes TestAccApiManagementLogger_updat…
rigalGit Jan 20, 2026
39b5e0d
Merge branch 'main' into jitendra/fix-TestAccApiManagementLogger_update
rigalGit Feb 2, 2026
a33f6be
addressed review changes by creating a new config with updated fields…
rigalGit Feb 2, 2026
e37951e
added TestAccApiManagementLogger_switchBetweenApplicationInsightsAndE…
rigalGit Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 90 additions & 13 deletions internal/services/apimanagement/api_management_logger_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import (

"github.com/hashicorp/go-azure-helpers/lang/pointer"
"github.com/hashicorp/go-azure-sdk/resource-manager/apimanagement/2022-08-01/logger"
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
"github.com/hashicorp/terraform-plugin-testing/plancheck"
"github.com/hashicorp/terraform-provider-azurerm/internal/acceptance"
"github.com/hashicorp/terraform-provider-azurerm/internal/acceptance/check"
"github.com/hashicorp/terraform-provider-azurerm/internal/clients"
Expand Down Expand Up @@ -191,55 +193,80 @@ func TestAccApiManagementLogger_update(t *testing.T) {
),
},
{
Config: r.basicEventHub(data),
Config: r.applicationInsightsUpdate(data, "Logger from Terraform test", "false"),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("buffered").HasValue("true"),
check.That(data.ResourceName).Key("description").HasValue(""),
check.That(data.ResourceName).Key("eventhub.#").HasValue("1"),
check.That(data.ResourceName).Key("eventhub.0.name").Exists(),
check.That(data.ResourceName).Key("eventhub.0.connection_string").Exists(),
check.That(data.ResourceName).Key("buffered").HasValue("false"),
check.That(data.ResourceName).Key("description").HasValue("Logger from Terraform test"),
check.That(data.ResourceName).Key("eventhub.#").HasValue("0"),
check.That(data.ResourceName).Key("application_insights.#").HasValue("1"),
check.That(data.ResourceName).Key("application_insights.0.instrumentation_key").Exists(),
),
},
{
Config: r.complete(data, "Logger from Terraform test", "false"),
Config: r.basicApplicationInsights(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("buffered").HasValue("false"),
check.That(data.ResourceName).Key("description").HasValue("Logger from Terraform test"),
check.That(data.ResourceName).Key("buffered").HasValue("true"),
check.That(data.ResourceName).Key("description").HasValue(""),
check.That(data.ResourceName).Key("eventhub.#").HasValue("0"),
check.That(data.ResourceName).Key("application_insights.#").HasValue("1"),
check.That(data.ResourceName).Key("application_insights.0.instrumentation_key").Exists(),
),
},
})
}

func TestAccApiManagementLogger_switchBetweenApplicationInsightsAndEventHub(t *testing.T) {
data := acceptance.BuildTestData(t, "azurerm_api_management_logger", "test")
r := ApiManagementLoggerResource{}
// switching between Application Insights and Event Hub requires recreation of the resource
data.ResourceTestIgnoreRecreate(t, r, []acceptance.TestStep{
{
Config: r.basicEventHub(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("buffered").HasValue("true"),
check.That(data.ResourceName).Key("description").HasValue(""),
check.That(data.ResourceName).Key("application_insights.#").HasValue("0"),
check.That(data.ResourceName).Key("eventhub.#").HasValue("1"),
check.That(data.ResourceName).Key("eventhub.0.name").Exists(),
check.That(data.ResourceName).Key("eventhub.0.connection_string").Exists(),
),
},
{
Config: r.complete(data, "Logger from Terraform update test", "true"),
Config: r.basicApplicationInsights(data),
ConfigPlanChecks: expectResourceActionCheck(data.ResourceName, plancheck.ResourceActionReplace),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("buffered").HasValue("true"),
check.That(data.ResourceName).Key("description").HasValue("Logger from Terraform update test"),
check.That(data.ResourceName).Key("description").HasValue(""),
check.That(data.ResourceName).Key("eventhub.#").HasValue("0"),
check.That(data.ResourceName).Key("application_insights.#").HasValue("1"),
check.That(data.ResourceName).Key("application_insights.0.instrumentation_key").Exists(),
),
},
{
Config: r.complete(data, "Logger from Terraform test", "false"),
Config: r.complete(data, "Logger from Terraform test", "false"),
ConfigPlanChecks: expectResourceActionCheck(data.ResourceName, plancheck.ResourceActionReplace),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("buffered").HasValue("false"),
check.That(data.ResourceName).Key("description").HasValue("Logger from Terraform test"),
check.That(data.ResourceName).Key("eventhub.#").HasValue("0"),
check.That(data.ResourceName).Key("application_insights.#").HasValue("1"),
check.That(data.ResourceName).Key("application_insights.0.instrumentation_key").Exists(),
check.That(data.ResourceName).Key("resource_id").Exists(),
),
},
{
Config: r.basicEventHub(data),
Config: r.basicEventHub(data),
ConfigPlanChecks: expectResourceActionCheck(data.ResourceName, plancheck.ResourceActionReplace),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("buffered").HasValue("true"),
check.That(data.ResourceName).Key("description").HasValue(""),
check.That(data.ResourceName).Key("application_insights.#").HasValue("0"),
check.That(data.ResourceName).Key("eventhub.#").HasValue("1"),
check.That(data.ResourceName).Key("eventhub.0.name").Exists(),
check.That(data.ResourceName).Key("eventhub.0.connection_string").Exists(),
Expand All @@ -248,6 +275,14 @@ func TestAccApiManagementLogger_update(t *testing.T) {
})
}

func expectResourceActionCheck(resourceName string, action plancheck.ResourceActionType) resource.ConfigPlanChecks {
return resource.ConfigPlanChecks{
PreApply: []plancheck.PlanCheck{
plancheck.ExpectResourceAction(resourceName, action),
},
}
}

func (ApiManagementLoggerResource) Exists(ctx context.Context, clients *clients.Client, state *pluginsdk.InstanceState) (*bool, error) {
id, err := logger.ParseLoggerID(state.ID)
if err != nil {
Expand Down Expand Up @@ -496,6 +531,48 @@ resource "azurerm_api_management_logger" "test" {
`, data.RandomInteger, data.Locations.Primary, data.RandomInteger, data.RandomInteger, data.RandomInteger)
}

func (ApiManagementLoggerResource) applicationInsightsUpdate(data acceptance.TestData, description, buffered string) string {
return fmt.Sprintf(`
provider "azurerm" {
features {}
}

resource "azurerm_resource_group" "test" {
name = "acctestRG-%[1]d"
location = "%[2]s"
}

resource "azurerm_application_insights" "test" {
name = "acctestappinsights-%[1]d"
location = azurerm_resource_group.test.location
resource_group_name = azurerm_resource_group.test.name
application_type = "other"
}

resource "azurerm_api_management" "test" {
name = "acctestAM-%[1]d"
location = azurerm_resource_group.test.location
resource_group_name = azurerm_resource_group.test.name
publisher_name = "pub1"
publisher_email = "pub1@email.com"

sku_name = "Consumption_0"
}

resource "azurerm_api_management_logger" "test" {
name = "acctestapimnglogger-%[1]d"
api_management_name = azurerm_api_management.test.name
resource_group_name = azurerm_resource_group.test.name
description = "%[3]s"
buffered = %[4]s

application_insights {
instrumentation_key = azurerm_application_insights.test.instrumentation_key
}
}
`, data.RandomInteger, data.Locations.Primary, description, buffered)
}

func (ApiManagementLoggerResource) applicationInsightsConnectionString(data acceptance.TestData) string {
return fmt.Sprintf(`
provider "azurerm" {
Expand Down
Loading