Skip to content

tests: migrate azurerm_public_ip SKU from Basic to Standard#31885

Open
teowa wants to merge 4 commits intohashicorp:mainfrom
teowa:public-ip-basic
Open

tests: migrate azurerm_public_ip SKU from Basic to Standard#31885
teowa wants to merge 4 commits intohashicorp:mainfrom
teowa:public-ip-basic

Conversation

@teowa
Copy link
Copy Markdown
Collaborator

@teowa teowa commented Mar 4, 2026

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

  • update tests of Public IP to migrate from Basic to Standard SKU
  • for public ip bound to virtual network gateway, zones are added due to API requirement:
    unexpected status 400 (400 Bad Request) with error: ZRStandardIpNeeded: Standard IP Address requires zones configured. Please use configure zones on the public Ip Address you are using.
  • for azuerm_lb, update sku from Basic to Standard, due to API requirement:
    unexpected status 400 (400 Bad Request) with error: PublicIPAndLBSkuDoNotMatch: Basic sku load balancer /subscriptions/*******/resourceGroups/acctestRG-260304112158032020/providers/Microsoft.Network/loadBalancers/acctestlb-260304112158032020 cannot reference Standard sku publicIP /subscriptions/*******/resourceGroups/acctestRG-260304112158032020/providers/Microsoft.Network/publicIPAddresses/acctestpip-260304112158032020.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_public_ip - block creation of Basic SKU Public IP resources while allowing existing resources to be updated [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related PR(s)

PR #31197

AI Assistance Disclosure

  • AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@github-actions github-actions Bot added size/L and removed size/XL labels Mar 4, 2026
@teowa teowa changed the title azurerm_public_ip - block creation of Basic SKU Public IP resources while allowing existing resources to be updated tests: migrate azurerm_public_ip SKU from Basic to Standard Mar 12, 2026
@WodansSon
Copy link
Copy Markdown
Collaborator

WodansSon commented Mar 12, 2026

@teowa, thank you so much for this, but I think we may have missed some services that also reference this resource in the below services, can we double check to make sure these tests won't regress due to the change in the parent PR:

  • apimanagement
  • arckubernetes
  • azurestackhci
  • containers
  • databricks
  • datafactory
  • extendedlocation
  • firewall
  • hdinsight
  • hsm
  • hybridcompute
  • loadbalancer
  • maintenance
  • nginx
  • paloalto
  • resource
  • storagemover
  • trafficmanager
  • vmware

I did a deep dive on the above resources, and the below services explicitly use sku = "Standard" in all tests:

  • apimanagement
  • azurestackhci
  • cdn
  • containers
  • databricks
  • datafactory
  • firewall
  • hdinsight
  • nginx
  • paloalto
  • vmware

The remaining services reference azurerm_public_ip in tests but do not set an explicit sku on that resource, so they will pick up whatever the new default is, so if that is Standard these tests should be fine as well:

  • arckubernetes
  • extendedlocation
  • hsm
  • hybridcompute
  • loadbalancer
  • maintenance
  • resource
  • storagemover
  • trafficmanager

So, for these services there is no Basic SKU usage that showed up in the services.

@teowa teowa force-pushed the public-ip-basic branch from 7331f2f to 7c496b3 Compare April 15, 2026 06:18
@teowa teowa marked this pull request as ready for review April 16, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants