tests: migrate azurerm_public_ip SKU from Basic to Standard#31885
Open
teowa wants to merge 4 commits intohashicorp:mainfrom
Open
tests: migrate azurerm_public_ip SKU from Basic to Standard#31885teowa wants to merge 4 commits intohashicorp:mainfrom
azurerm_public_ip SKU from Basic to Standard#31885teowa wants to merge 4 commits intohashicorp:mainfrom
Conversation
…ng resources to be updated
15 tasks
azurerm_public_ip - block creation of Basic SKU Public IP resources while allowing existing resources to be updatedazurerm_public_ip SKU from Basic to Standard
Collaborator
|
@teowa, thank you so much for this, but I think we may have missed some services that also reference this resource in the below services, can we double check to make sure these tests won't regress due to the change in the parent PR:
I did a deep dive on the above resources, and the below services explicitly use
The remaining services reference
So, for these services there is no |
…m into public-ip-basic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
BasictoStandardSKUunexpected status 400 (400 Bad Request) with error: ZRStandardIpNeeded: Standard IP Address requires zones configured. Please use configure zones on the public Ip Address you are using.BasictoStandard, due to API requirement:unexpected status 400 (400 Bad Request) with error: PublicIPAndLBSkuDoNotMatch: Basic sku load balancer /subscriptions/*******/resourceGroups/acctestRG-260304112158032020/providers/Microsoft.Network/loadBalancers/acctestlb-260304112158032020 cannot reference Standard sku publicIP /subscriptions/*******/resourceGroups/acctestRG-260304112158032020/providers/Microsoft.Network/publicIPAddresses/acctestpip-260304112158032020.PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_public_ip- block creation of Basic SKU Public IP resources while allowing existing resources to be updated [GH-00000]This is a (please select all that apply):
Related PR(s)
PR #31197
AI Assistance Disclosure
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.