azurerm_kubernetes_cluster and azurerm_kubernetes_cluster_node_pool - support local_dns_profile#32379
Conversation
|
"Related issues" in PR description should include "Fixes #31342" as that is the original request. The currently listed numbers are for unmerged PRs. |
840177a to
2f548c7
Compare
|
Hi @hqhqhqhqhqhqhqhqhqhqhq , thanks for the PR. left some comments and took a look at the test result, there is a new test failure: TestAccKubernetesCluster_upgradeControlPlaneAndAllPoolsTogetherSpot Could you please take a look if it's related to this PR? |
2f548c7 to
6fe0567
Compare
gerrytan
left a comment
There was a problem hiding this comment.
Thanks @hqhqhqhqhqhqhqhqhqhqhq , I left some concerns to address below. Also when it's ready for another review, can you please run the entire acctest suite of affected tests, not just the newly added ones. You can use tctest tool to help you. Don't worry about pre-existing failures, the reviewers will take that into account when assessing the acctest result.
gerrytan
left a comment
There was a problem hiding this comment.
Thanks for addressing all the feedbacks @hqhqhqhqhqhqhqhqhqhqhq , just need another TC test run. I am approving in advance provided all TC test result is good.
3ee9d6c to
57ff5db
Compare
|
Thanks, it mostly LGTM just 2 minor questions. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f8c6233 to
a87abb6
Compare
This comment has been minimized.
This comment has been minimized.
|
@hqhqhqhqhqhqhqhqhqhqhq - One or more tests failed in this PR. Please review the failures. Testing in Beta version enabled Total: 292 Test Details
|
|
@hqhqhqhqhqhqhqhqhqhqhq - One or more tests failed in this PR. Please review the failures. Total: 294 Test Details
|
|
/test -b -q -s containers |
Community Note
Description
This PR adds support for the
local_dns_profileblock on AKS node pools through:azurerm_kubernetes_cluster.default_node_pool.local_dns_profileazurerm_kubernetes_cluster_node_pool.local_dns_profileThe new block maps the AKS LocalDNS profile fields exposed by the
2025-10-01Container Service API, including the LocalDNS mode plus VNet and Kubernetes DNS override maps. The implementation wires the field through create, update, read, import flattening, acceptance tests, and resource documentation.This is a Harry-authored replacement for closed PR #31987. During the duplicate PR check I found open PR #32348, which appears to overlap this feature.
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
This is a (please select all that apply):
Related Issue(s)
Fixes #31342
AI Assistance Disclosure
AI assistance was used to port the implementation from the closed PR, resolve conflicts against current
main, draft documentation/test updates, run validation commands, and prepare this PR description.Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
No changes to security controls.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.