Add support for sync resource in HCP Vault Secrets#1196
Merged
rodrigo-hcp merged 16 commits intomainfrom Mar 14, 2025
Merged
Conversation
rodrigo-hcp
force-pushed
the
new-sync-resource
branch
3 times, most recently
from
f563a43 to
76017a2
Compare
rodrigo-hcp
force-pushed
the
new-sync-resource
branch
from
76017a2 to
6b2eafb
Compare
dhuckins
reviewed
Feb 3, 2025
rodrigo-hcp
force-pushed
the
new-sync-resource
branch
2 times, most recently
from
917055f to
4d3e497
Compare
rodrigo-hcp
force-pushed
the
new-sync-resource
branch
from
4d3e497 to
ae2358f
Compare
pmmukh
previously approved these changes
Feb 6, 2025
Contributor
pmmukh
left a comment
pmmukh
left a comment
There was a problem hiding this comment.
would rec a 2nd review, not well versed in TFP thing, but overall looks great to me!
rodrigo-hcp
force-pushed
the
new-sync-resource
branch
from
b239121 to
acaae18
Compare
maxcoulombe
reviewed
Feb 7, 2025
maxcoulombe
reviewed
Feb 7, 2025
maxcoulombe
reviewed
Feb 7, 2025
rodrigo-hcp
force-pushed
the
new-sync-resource
branch
from
3aaead1 to
8fd7739
Compare
rodrigo-hcp
force-pushed
the
new-sync-resource
branch
from
c73cbba to
92ac02f
Compare
…cs from existing app (while preserving the app)
rodrigo-hcp
force-pushed
the
new-sync-resource
branch
2 times, most recently
from
fef2586 to
9f180b9
Compare
maxcoulombe
reviewed
Feb 13, 2025
rodrigo-hcp
force-pushed
the
new-sync-resource
branch
from
9f180b9 to
5648962
Compare
rodrigo-hcp
force-pushed
the
new-sync-resource
branch
from
5648962 to
7aa1591
Compare
rodrigo-hcp
force-pushed
the
new-sync-resource
branch
from
614aade to
38c2cea
Compare
rodrigo-hcp
force-pushed
the
new-sync-resource
branch
from
3bc58ab to
c6e9699
Compare
rodrigo-hcp
force-pushed
the
new-sync-resource
branch
from
50b7518 to
3c58b56
Compare
rodrigo-hcp
force-pushed
the
new-sync-resource
branch
from
3c58b56 to
ccceb56
Compare
maxcoulombe
approved these changes
Feb 20, 2025
|
This PR is more than 2 weeks old. Please remove the stale label, update, or comment if this PR is still valid and relevant, otherwise it will be closed in 7 days. |
huikang
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test scenarios
sync_names:planwill warn of removal of syncs from app.syncresource🛠️ Description
🏗️ Acceptance tests
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccVaultSecretsResourceSync' ...