chore: Remove PSS-related gating flag/ENV in the init command#38268
Draft
SarahFrench wants to merge 2 commits intomainfrom
Draft
chore: Remove PSS-related gating flag/ENV in the init command#38268SarahFrench wants to merge 2 commits intomainfrom
SarahFrench wants to merge 2 commits intomainfrom
Conversation
Closed
3 tasks
mildwonkey
reviewed
Mar 12, 2026
| } | ||
|
|
||
| args := []string{"-enable-pluggable-state-storage-experiment=true"} | ||
| args := []string{} |
Contributor
There was a problem hiding this comment.
This is just a note for future code writing, no changes needed, but for what it's worth, c.Run(nil) or c.Run([]string{}) also work fine, and don't allocate an otherwise unused variable. I try to avoid variables that aren't adding anything but lines (again, not hurting anything, no changes needed).
mildwonkey
approved these changes
Mar 12, 2026
Member
Author
|
We've decided to pause removing this until GA, so I'm gonna save merging this until the next beta is out |
Member
|
Marking this as draft for now until we are ready to remove the gating, as per our Slack conversation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #38227
That previous PR combines the two versions of
initlogic that were present when PSS was in earlier development (see PR description). The choice of which version to use was controlled by a flag-enable-pluggable-state-storage-experiment, and that PR removed the ability to make that choice; all users now experience the new init flow that is necessary for PSS.It should now be that anyone can use PSS as long as experiments are enabled (and they have a provider implementing it). However that alpha still returns this error that enforces the flag being provided:
This PR removes remaining code related to the flag
-enable-pluggable-state-storage-experimentand the related ENVTF_ENABLE_PLUGGABLE_STATE_STORAGE.Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry
It is technically user-facing, but this is all still gated behind experiments being enabled, so not user facing by the definition that matters here.