Skip to content

Conversation

@sprakhashi
Copy link

Please go to the Preview tab and select the appropriate template:

@sprakhashi sprakhashi requested review from a team as code owners December 1, 2025 21:01
@hashicorp-cla-app
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Tue Dec 2 20:33:16 UTC 2025
Unified Docs API ✅ Ready (Inspect) Visit Preview Tue Dec 2 20:28:30 UTC 2025

@sprakhashi sprakhashi requested a review from a team as a code owner December 1, 2025 21:17
Comment on lines 248 to 250
'content/consul/**',
'content/nomad/**',
'content/hcp-docs/content/docs/cli/**',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just ignore the label error, it shouldn't block the pr

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I added the fix, just in case

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Broken Link Checker

No broken links found! 🎉

@include 'beta-feature.mdx'

Vault Radar allows you to connect to any workspace on [Slack
Cloud](#add-slack-cloud).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "Slack Cloud" the correct term? Is it not just Slack? I know we typically have to distinguish between the two, but I think for simplicty we can drop the cloud references unless it's part of the offical brand name.

Vault Radar allows you to connect to any workspace on [Slack
Cloud](#add-slack-cloud).

## Add Slack Cloud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible alternative

Suggested change
## Add Slack Cloud
## Add a Slack Data Source


## Add Slack Cloud

## Create a connection with Slack Cloud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an unnecessary rephrasing of the above heading?

Suggested change
## Create a connection with Slack Cloud

1. Click on the **Connect to Slack** button to initiate the OAuth flow
![Initiate OAuth flow](/img/docs/vault-radar/initiate-slack-oauth-flow.png)

1. Select the workspace in the dropdown list and click **Allow**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
1. Select the workspace in the dropdown list and click **Allow**
1. Select the workspace from the dropdown list and click **Allow**

1. Select the workspace in the dropdown list and click **Allow**
![Install Slack App onto a workspace](/img/docs/vault-radar/install-slack-app-to-workspace.png)

1. Once the app is installed successfully, the UI will display the message **Authenticated to Slack**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Once the app is installed successfully, the UI will display the message **Authenticated to Slack**
1. Once the app is installed successfully, the HCP Vault Radar UI will display the message **Authenticated to Slack**


## Create a connection with Slack Cloud

### Install the Slack App onto a workspace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the instructions, I think it makes more sense not to break this up into subsections.

The reality is that a user needs to start onboarding their data source, then add the app to their Slack workspace, then come back to onboarding their data source. And I think we want them to do that as one complete workflow and not suggest that it can be broken up into different workflows.

Thoughts?

Specifically, I'd just delete the headings: ### Install the Slack App onto a workspace and ### Scan with HCP Cloud

cc: @jonathanfrappier

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following the other data source format. It makes sense to have one section to onboard the slack datasource


## Add channels to Vault Radar

1. Once you establish a connection, select either **All active channels** or **Select channels to monitor** radio button.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Once you establish a connection, select either **All active channels** or **Select channels to monitor** radio button.
1. Once the Slack data source is onboarded, select either **All active channels** or **Select channels to monitor** radio button.

1. Click on **Next** to continue the onboarding process


## Add channels to Vault Radar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, this is still part of the Onboarding workflow. It could be combined with the instructions in the previous section.

cc: @jonathanfrappier

Copy link
Contributor

@JoshAtHC JoshAtHC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, up to you on whether you want to include the changes made to the labeler.yml or let the owners sort it out

@github-actions github-actions bot added the HCP label Dec 2, 2025
@sprakhashi
Copy link
Author

LGTM, up to you on whether you want to include the changes made to the labeler.yml or let the owners sort it out

I would leave the changes, it's not a functional issue, a more syntax one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants