-
Notifications
You must be signed in to change notification settings - Fork 112
RADAR-6702 | Add slack cloud data source onboarding doc #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
Vercel Previews Deployed
|
| 'content/consul/**', | ||
| 'content/nomad/**', | ||
| 'content/hcp-docs/content/docs/cli/**', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can just ignore the label error, it shouldn't block the pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I added the fix, just in case
Broken Link CheckerNo broken links found! 🎉 |
| @include 'beta-feature.mdx' | ||
|
|
||
| Vault Radar allows you to connect to any workspace on [Slack | ||
| Cloud](#add-slack-cloud). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "Slack Cloud" the correct term? Is it not just Slack? I know we typically have to distinguish between the two, but I think for simplicty we can drop the cloud references unless it's part of the offical brand name.
| Vault Radar allows you to connect to any workspace on [Slack | ||
| Cloud](#add-slack-cloud). | ||
|
|
||
| ## Add Slack Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible alternative
| ## Add Slack Cloud | |
| ## Add a Slack Data Source |
|
|
||
| ## Add Slack Cloud | ||
|
|
||
| ## Create a connection with Slack Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like an unnecessary rephrasing of the above heading?
| ## Create a connection with Slack Cloud |
| 1. Click on the **Connect to Slack** button to initiate the OAuth flow | ||
|  | ||
|
|
||
| 1. Select the workspace in the dropdown list and click **Allow** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
| 1. Select the workspace in the dropdown list and click **Allow** | |
| 1. Select the workspace from the dropdown list and click **Allow** |
| 1. Select the workspace in the dropdown list and click **Allow** | ||
|  | ||
|
|
||
| 1. Once the app is installed successfully, the UI will display the message **Authenticated to Slack** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 1. Once the app is installed successfully, the UI will display the message **Authenticated to Slack** | |
| 1. Once the app is installed successfully, the HCP Vault Radar UI will display the message **Authenticated to Slack** |
|
|
||
| ## Create a connection with Slack Cloud | ||
|
|
||
| ### Install the Slack App onto a workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading the instructions, I think it makes more sense not to break this up into subsections.
The reality is that a user needs to start onboarding their data source, then add the app to their Slack workspace, then come back to onboarding their data source. And I think we want them to do that as one complete workflow and not suggest that it can be broken up into different workflows.
Thoughts?
Specifically, I'd just delete the headings: ### Install the Slack App onto a workspace and ### Scan with HCP Cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following the other data source format. It makes sense to have one section to onboard the slack datasource
|
|
||
| ## Add channels to Vault Radar | ||
|
|
||
| 1. Once you establish a connection, select either **All active channels** or **Select channels to monitor** radio button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 1. Once you establish a connection, select either **All active channels** or **Select channels to monitor** radio button. | |
| 1. Once the Slack data source is onboarded, select either **All active channels** or **Select channels to monitor** radio button. |
| 1. Click on **Next** to continue the onboarding process | ||
|
|
||
|
|
||
| ## Add channels to Vault Radar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this is still part of the Onboarding workflow. It could be combined with the instructions in the previous section.
JoshAtHC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, up to you on whether you want to include the changes made to the labeler.yml or let the owners sort it out
I would leave the changes, it's not a functional issue, a more syntax one |
Please go to the
Previewtab and select the appropriate template: