-
Notifications
You must be signed in to change notification settings - Fork 112
RADAR-6702 | Add slack cloud data source onboarding doc #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
ca63b36
7c42ec4
1d9a073
6e374b2
cb66619
24a15fd
041f7ad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,56 @@ | ||||||
| --- | ||||||
| page_title: Add a data source - Slack | ||||||
| description: >- | ||||||
| Add Slack as a data source for Vault Radar. | ||||||
| --- | ||||||
|
|
||||||
| # Add a data source - Slack | ||||||
|
|
||||||
| @include 'beta-feature.mdx' | ||||||
|
|
||||||
| Vault Radar allows you to connect to any workspace on [Slack | ||||||
| Cloud](#add-slack-cloud). | ||||||
|
||||||
|
|
||||||
| ## Add Slack Cloud | ||||||
|
||||||
| ## Add Slack Cloud | |
| ## Add a Slack Data Source |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like an unnecessary rephrasing of the above heading?
| ## Create a connection with Slack Cloud |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading the instructions, I think it makes more sense not to break this up into subsections.
The reality is that a user needs to start onboarding their data source, then add the app to their Slack workspace, then come back to onboarding their data source. And I think we want them to do that as one complete workflow and not suggest that it can be broken up into different workflows.
Thoughts?
Specifically, I'd just delete the headings: ### Install the Slack App onto a workspace and ### Scan with HCP Cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following the other data source format. It makes sense to have one section to onboard the slack datasource
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
| 1. Select the workspace in the dropdown list and click **Allow** | |
| 1. Select the workspace from the dropdown list and click **Allow** |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 1. Once the app is installed successfully, the UI will display the message **Authenticated to Slack** | |
| 1. Once the app is installed successfully, the HCP Vault Radar UI will display the message **Authenticated to Slack** |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this is still part of the Onboarding workflow. It could be combined with the instructions in the previous section.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 1. Once you establish a connection, select either **All active channels** or **Select channels to monitor** radio button. | |
| 1. Once the Slack data source is onboarded, select either **All active channels** or **Select channels to monitor** radio button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can just ignore the label error, it shouldn't block the pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I added the fix, just in case