Make all config options mandatory#541
Conversation
WalkthroughMoves many Tailscale behaviors from implicit defaults to explicit opt-in, tightens the add-on config schema (many fields made required/stricter), introduces a Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Sys as s6/System
participant Post as post-tailscaled
participant TS as tailscaled
participant CFG as config.yaml
participant LOG as Logger
Note over CFG: Flags must be explicit true/false
Sys->>TS: start tailscaled
TS-->>Sys: ready
Sys->>Post: run post-tailscaled
Post->>CFG: read flags (accept_dns, accept_routes, advertise_*, userspace_networking, snat/stateful, tags)
alt flag == true
Post->>TS: append --<flag>=true
else
Post->>TS: append --<flag>=false
end
Post->>TS: append --login-server=<url> (always)
alt advertise_exit_node == true and exit_node set
Post->>LOG: warn about exit-node conflict
end
sequenceDiagram
autonumber
participant Caller as Caller
participant SR as subnet-routes
participant CFG as config
participant IF as NetworkInterfaces
participant LOG as Logger
Caller->>SR: invoke mode ("advertised" or other)
alt mode = "advertised"
SR->>CFG: read advertise_routes
alt contains "local_subnets"
SR->>IF: run `subnet-routes local` -> collect local subnets
alt none found
SR->>LOG: warn "There are no local subnets to advertise!"
end
end
SR->>SR: merge explicit CIDRs from advertise_routes (skip sentinel)
else
SR->>IF: collect interface IPs and extract networks
end
SR->>SR: deduplicate & sort routes
SR-->>Caller: emit routes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
frenck
added
the
refactor
lmagyar
force-pushed
the
pr-mandatory-options
branch
from
0270a14 to
d2acb2c
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tailscale/rootfs/usr/bin/subnet-routes (1)
50-58: Exclude loopback addresses to avoid advertising 127.0.0.0/8 or ::1/128.Current filters skip link-local but not loopback. With local.subnets, this could generate bogus routes.
Apply this diff:
# Extract routes from addresses for address in "${addresses[@]}"; do if bashio::var.has_value "${address}"; then + # Skip loopback addresses + if [[ "${address}" == 127.* ]] || [[ "${address:0:3}" == "::1" ]]; then + continue + fi # Skip local link addresses if [[ "${address:0:6}" == "fe80::" ]] || [[ "${address:0:8}" == "169.254." ]]; then continue fi
🧹 Nitpick comments (2)
tailscale/DOCS.md (1)
66-86: Consider showing the local.subnets sentinel in the sample YAML.Helps users discover the new default/shortcut.
Apply this diff:
advertise_routes: - - 192.168.1.0/24 + - local.subnets # Advertise all local subnets discovered on supported interfaces + - 192.168.1.0/24 - fd12:3456:abcd::/64tailscale/rootfs/etc/s6-overlay/s6-rc.d/share-homeassistant/run (1)
15-19: Gracefully handle share_homeassistant=disabled in case gating fails.If stage removal ever regresses, this service would crash-loop on “disabled”. Early no-op is safer.
Apply this diff:
# Validate share_homeassistant value -if ! bashio::config.equals 'share_homeassistant' 'serve' && \ - ! bashio::config.equals 'share_homeassistant' 'funnel' -then - bashio::exit.nok "Invalid value '$(bashio::config 'share_homeassistant')' for share_homeassistant. Must be either 'serve' or 'funnel'" -fi +if bashio::config.equals 'share_homeassistant' 'disabled'; then + bashio::log.info "share_homeassistant=disabled; skipping Serve/Funnel setup." + exit 0 +fi +if ! bashio::config.equals 'share_homeassistant' 'serve' && \ + ! bashio::config.equals 'share_homeassistant' 'funnel'; then + bashio::exit.nok "Invalid value '$(bashio::config 'share_homeassistant')' for share_homeassistant. Must be 'serve', 'funnel', or 'disabled'." +fi
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
tailscale/DOCS.md(12 hunks)tailscale/config.yaml(1 hunks)tailscale/rootfs/etc/s6-overlay/s6-rc.d/post-tailscaled/run(4 hunks)tailscale/rootfs/etc/s6-overlay/s6-rc.d/share-homeassistant/run(1 hunks)tailscale/rootfs/etc/s6-overlay/s6-rc.d/tailscaled/run(1 hunks)tailscale/rootfs/etc/s6-overlay/scripts/stage2_hook.sh(2 hunks)tailscale/rootfs/usr/bin/subnet-routes(3 hunks)tailscale/translations/en.yaml(3 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2024-11-15T17:38:56.576Z
Learnt from: lmagyar
PR: hassio-addons/addon-tailscale#419
File: tailscale/rootfs/command/with-contenv-merge:8-12
Timestamp: 2024-11-15T17:38:56.576Z
Learning: The script `with-contenv-merge` in `tailscale/rootfs/command/` is directly copied from s6 and should not be modified.
Applied to files:
tailscale/rootfs/etc/s6-overlay/s6-rc.d/tailscaled/runtailscale/rootfs/etc/s6-overlay/s6-rc.d/share-homeassistant/runtailscale/rootfs/etc/s6-overlay/s6-rc.d/post-tailscaled/run
📚 Learning: 2024-10-09T10:32:14.110Z
Learnt from: mikz
PR: hassio-addons/addon-tailscale#407
File: tailscale/rootfs/etc/s6-overlay/s6-rc.d/init-nginx/run:24-29
Timestamp: 2024-10-09T10:32:14.110Z
Learning: In the Tailscale add-on for Home Assistant, the `tailscale/rootfs` directory is copied into the container's root directory via the Dockerfile, ensuring that files like `/etc/nginx/templates/homeassistant.gtpl` are present at runtime.
Applied to files:
tailscale/DOCS.md
📚 Learning: 2025-06-11T20:37:01.152Z
Learnt from: lmagyar
PR: hassio-addons/addon-tailscale#455
File: tailscale/rootfs/usr/bin/magicdns-ingress-proxy-forwarding:100-106
Timestamp: 2025-06-11T20:37:01.152Z
Learning: In the Home Assistant Tailscale add-on, DNATing DNS packets to port 0 (e.g. `--to-destination 127.0.0.1:0`) is an intentional technique to drop traffic. iptables accepts port 0, rewrites the destination port to 0, and the packet is rejected by the stack, effectively discarding it. This is valid and should not be flagged as an error in future reviews.
Applied to files:
tailscale/DOCS.md
🔇 Additional comments (19)
tailscale/translations/en.yaml (1)
8-8: LGTM on standardizing the “enabled/disabled by default” phrasing.Consistent with the “mandatory config” direction and clearer for users.
Also applies to: 14-14, 21-21, 29-29, 63-63, 70-70, 78-78, 85-85, 96-96, 104-104
tailscale/DOCS.md (1)
294-294: LGTM: default port wording.Matches the tightened schema and the run script using the configured port.
tailscale/rootfs/usr/bin/subnet-routes (2)
72-74: LGTM: unique the route list.Ensures stable, deduplicated output for downstream consumers.
27-41: Approve — schema already allows literallocal.subnets
config.yaml advertise_routes pattern includes the literal "local.subnets" (line 52); no schema change required.tailscale/rootfs/etc/s6-overlay/s6-rc.d/share-homeassistant/run (1)
72-72: LGTM: use configured HTTPS port.
Uses the schema-constrained value instead of hardcoding 443.
Stage gating verified: stage2 hook removes /etc/s6-overlay/s6-rc.d/user/contents.d/share-homeassistant when share_homeassistant is 'disabled'.tailscale/rootfs/etc/s6-overlay/s6-rc.d/tailscaled/run (1)
26-29: LGTM — only enable userspace networking when explicitly true; default verified trueVerified: config.yaml contains
userspace_networking: true(line 45) and the schema listsuserspace_networking: bool(line 63).tailscale/rootfs/etc/s6-overlay/scripts/stage2_hook.sh (4)
62-66: LGTM: gating for protect-subnets matches the new explicit semantics.
75-77: LGTM: forwarding removal correctly keys off userspace networking.
80-82: LGTM: mss-clamping removal aligns with userspace networking constraints.
90-92: LGTM: share-homeassistant only removed when explicitly disabled.tailscale/rootfs/etc/s6-overlay/s6-rc.d/post-tailscaled/run (8)
19-25: LGTM: explicit accept-dns/accept-routes flags with explicit false when not enabled.Also applies to: 26-32
34-38: LGTM: exit-node conflict guard and explicit advertise-exit-node toggling are correct.Also applies to: 40-46
57-63: LGTM: advertise-connector is now explicit; good.
65-67: LGTM: login_server always passed; consistent with required schema default.
83-85: LGTM: tags join is safe; empty list yields empty string.
170-178: LGTM: userspace networking notice gated on explicit true.
68-74: No action needed — bundled Tailscale (v1.88.1) supports these flags.
tailscale/Dockerfile sets ARG TAILSCALE_VERSION="v1.88.1"; --stateful-filtering was added in v1.66.0 and --snat-subnet-routes is available, so these flags are supported and startup should not fail.
150-156: Sort both comm inputs to avoid false negativescomm requires both inputs to be sorted; sort the local routes before comparing.
File: tailscale/rootfs/etc/s6-overlay/s6-rc.d/post-tailscaled/run (around lines 150-156)
- comm -1 -2 \ - <(subnet-routes local) \ - <(/opt/tailscale status --json --peers=true --self=false \ + comm -1 -2 \ + <(subnet-routes local | sort -u) \ + <(/opt/tailscale status --json --peers=true --self=false \ | jq -rc '.Peer[] | select(has("PrimaryRoutes")) | .PrimaryRoutes[]' \ | sort -u))Run on a device with multiple peers to confirm expected warnings.
tailscale/config.yaml (1)
47-63: LGTM: booleans now required; patterns and enums look consistent with script expectations.
|
I've reviewed all the AI reviews, it's ready for human review. |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
Bot
added
stale
There was a problem hiding this comment.
Pull Request Overview
This PR makes configuration options mandatory rather than optional, standardizing the add-on's behavior by requiring explicit user choices for all settings. The change removes ambiguity about default behaviors and ensures consistent configuration across installations.
Key Changes:
- Made all configuration options mandatory with explicit defaults (except
exit_nodewhich remains optional) - Introduced
local_subnetsas a special value foradvertise_routesto auto-discover and advertise local subnet routes - Updated documentation to reflect that defaults are now explicitly set rather than implicitly applied when options are unset
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tailscale/config.yaml | Added options section with default values for all configuration parameters and removed ? optional markers from schema definitions |
| tailscale/translations/en.yaml | Updated configuration descriptions to replace "When not set, this option is..." with "This option is..." for clarity |
| tailscale/DOCS.md | Enhanced documentation with step-by-step UI instructions for enabling features and updated default value wording |
| tailscale/rootfs/etc/s6-overlay/scripts/stage2_hook.sh | Simplified conditional logic by removing checks for undefined configuration values |
| tailscale/rootfs/etc/s6-overlay/s6-rc.d/tailscaled/run | Removed checks for undefined userspace_networking configuration |
| tailscale/rootfs/etc/s6-overlay/s6-rc.d/post-tailscaled/run | Simplified conditionals by removing undefined value checks and updated tags configuration handling |
| tailscale/rootfs/etc/s6-overlay/s6-rc.d/share-homeassistant/run | Removed default value fallback for share_on_port |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tailscale/rootfs/usr/bin/subnet-routes (1)
27-41: Consider usingappendarrayfor defensive coding.The logic correctly handles the
local_subnetssentinel value. However, at line 32,readarray -t routesoverwrites the routes array rather than appending to it. If the configuration contains multiplelocal_subnetsentries (though unlikely), each subsequent occurrence would discard the previous results.Consider applying this diff to use the existing
appendarrayhelper:if [[ "${address}" =~ ^local_subnets$ ]]; then # Handle special value, collect local subnets - readarray -t routes < <(subnet-routes local) + appendarray routes < <(subnet-routes local) if (( 0 == ${#routes[@]} )); thenThis makes the code more defensive by appending rather than overwriting. Any resulting duplicates will be removed by the deduplication at line 73.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
tailscale/config.yaml(1 hunks)tailscale/rootfs/etc/s6-overlay/scripts/stage2_hook.sh(2 hunks)tailscale/rootfs/usr/bin/subnet-routes(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- tailscale/rootfs/etc/s6-overlay/scripts/stage2_hook.sh
- tailscale/config.yaml
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: lmagyar
Repo: hassio-addons/addon-tailscale PR: 541
File: tailscale/config.yaml:30-37
Timestamp: 2025-09-16T23:47:20.987Z
Learning: In the hassio-addons/addon-tailscale project, the advertise_routes configuration uses `local_subnets` (with underscore) as the default value, and the runtime regex patterns use `local.subnets` (with dot) which correctly matches the underscore variant because '.' in regex matches any single character including '_'.
Learnt from: lmagyar
Repo: hassio-addons/addon-tailscale PR: 509
File: tailscale/config.yaml:0-0
Timestamp: 2025-09-17T23:53:19.467Z
Learning: In the Tailscale add-on config.yaml, there is an intentional naming mismatch between map entries and schema field names: map entries use actual Home Assistant directory names (like `homeassistant_config`, `all_addon_configs`) while schema fields use user-friendly names (like `config`, `addon_configs`). This allows correct directory mapping while presenting cleaner option names in the UI.
📚 Learning: 2025-09-16T23:47:20.987Z
Learnt from: lmagyar
Repo: hassio-addons/addon-tailscale PR: 541
File: tailscale/config.yaml:30-37
Timestamp: 2025-09-16T23:47:20.987Z
Learning: In the hassio-addons/addon-tailscale project, the advertise_routes configuration uses `local_subnets` (with underscore) as the default value, and the runtime regex patterns use `local.subnets` (with dot) which correctly matches the underscore variant because '.' in regex matches any single character including '_'.
Applied to files:
tailscale/rootfs/usr/bin/subnet-routes
📚 Learning: 2025-11-06T10:55:55.062Z
Learnt from: lmagyar
Repo: hassio-addons/addon-tailscale PR: 566
File: tailscale/rootfs/usr/bin/subnet-routes:1-2
Timestamp: 2025-11-06T10:55:55.062Z
Learning: In the hassio-addons/addon-tailscale project, utility scripts in `/usr/bin/` (like `subnet-routes`, `protect-subnet-routes`, `unprotect-subnet-routes`) are invoked from s6-overlay service scripts or NetworkManager dispatchers that already use `#!/command/with-contenv bashio`. These utilities inherit the environment from their parent processes and therefore use `#!/usr/bin/env bashio` rather than `#!/command/with-contenv bashio`.
Applied to files:
tailscale/rootfs/usr/bin/subnet-routes
📚 Learning: 2025-10-29T20:47:02.818Z
Learnt from: lmagyar
Repo: hassio-addons/addon-tailscale PR: 562
File: tailscale/rootfs/etc/s6-overlay/s6-rc.d/post-tailscaled/run:120-128
Timestamp: 2025-10-29T20:47:02.818Z
Learning: In the hassio-addons/addon-tailscale project, when checking for IPv6 addresses in bash scripts, use the regex format `if [[ "${variable}" =~ .*:.* ]]; then` for consistency with other IPv6 tests in the codebase.
Applied to files:
tailscale/rootfs/usr/bin/subnet-routes
🔇 Additional comments (2)
tailscale/rootfs/usr/bin/subnet-routes (2)
33-36: LGTM!The warning appropriately alerts users when
local_subnetsis configured but no local subnets are available, and clearly states that a restart is required after fixing the underlying issue.
50-50: LGTM!The comment updates improve clarity by explicitly stating what is being processed: "from addresses" at line 50 and "from routes" at line 72.
Also applies to: 72-72
No. This is fine. After that |
lmagyar
force-pushed
the
pr-mandatory-options
branch
from
e1fae32 to
647cde2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
tailscale/DOCS.md(12 hunks)tailscale/config.yaml(1 hunks)tailscale/rootfs/etc/s6-overlay/s6-rc.d/post-tailscaled/run(4 hunks)tailscale/rootfs/etc/s6-overlay/s6-rc.d/share-homeassistant/run(1 hunks)tailscale/rootfs/etc/s6-overlay/s6-rc.d/tailscaled/run(1 hunks)tailscale/rootfs/etc/s6-overlay/scripts/stage2_hook.sh(2 hunks)tailscale/rootfs/usr/bin/subnet-routes(3 hunks)tailscale/translations/en.yaml(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (6)
- tailscale/rootfs/etc/s6-overlay/s6-rc.d/share-homeassistant/run
- tailscale/rootfs/etc/s6-overlay/s6-rc.d/post-tailscaled/run
- tailscale/rootfs/usr/bin/subnet-routes
- tailscale/DOCS.md
- tailscale/rootfs/etc/s6-overlay/scripts/stage2_hook.sh
- tailscale/translations/en.yaml
🧰 Additional context used
🧠 Learnings (8)
📓 Common learnings
Learnt from: lmagyar
Repo: hassio-addons/addon-tailscale PR: 541
File: tailscale/config.yaml:30-37
Timestamp: 2025-09-16T23:47:20.987Z
Learning: In the hassio-addons/addon-tailscale project, the advertise_routes configuration uses `local_subnets` (with underscore) as the default value, and the runtime regex patterns use `local.subnets` (with dot) which correctly matches the underscore variant because '.' in regex matches any single character including '_'.
📚 Learning: 2025-09-17T23:53:19.467Z
Learnt from: lmagyar
Repo: hassio-addons/addon-tailscale PR: 509
File: tailscale/config.yaml:0-0
Timestamp: 2025-09-17T23:53:19.467Z
Learning: In the Tailscale add-on config.yaml, there is an intentional naming mismatch between map entries and schema field names: map entries use actual Home Assistant directory names (like `homeassistant_config`, `all_addon_configs`) while schema fields use user-friendly names (like `config`, `addon_configs`). This allows correct directory mapping while presenting cleaner option names in the UI.
Applied to files:
tailscale/config.yaml
📚 Learning: 2025-09-16T23:47:20.987Z
Learnt from: lmagyar
Repo: hassio-addons/addon-tailscale PR: 541
File: tailscale/config.yaml:30-37
Timestamp: 2025-09-16T23:47:20.987Z
Learning: In the hassio-addons/addon-tailscale project, the advertise_routes configuration uses `local_subnets` (with underscore) as the default value, and the runtime regex patterns use `local.subnets` (with dot) which correctly matches the underscore variant because '.' in regex matches any single character including '_'.
Applied to files:
tailscale/config.yaml
📚 Learning: 2025-10-29T20:47:02.818Z
Learnt from: lmagyar
Repo: hassio-addons/addon-tailscale PR: 562
File: tailscale/rootfs/etc/s6-overlay/s6-rc.d/post-tailscaled/run:120-128
Timestamp: 2025-10-29T20:47:02.818Z
Learning: In the hassio-addons/addon-tailscale project, when checking for IPv6 addresses in bash scripts, use the regex format `if [[ "${variable}" =~ .*:.* ]]; then` for consistency with other IPv6 tests in the codebase.
Applied to files:
tailscale/config.yaml
📚 Learning: 2024-11-15T17:38:56.576Z
Learnt from: lmagyar
Repo: hassio-addons/addon-tailscale PR: 419
File: tailscale/rootfs/command/with-contenv-merge:8-12
Timestamp: 2024-11-15T17:38:56.576Z
Learning: The script `with-contenv-merge` in `tailscale/rootfs/command/` is directly copied from s6 and should not be modified.
Applied to files:
tailscale/config.yamltailscale/rootfs/etc/s6-overlay/s6-rc.d/tailscaled/run
📚 Learning: 2025-11-06T10:55:55.062Z
Learnt from: lmagyar
Repo: hassio-addons/addon-tailscale PR: 566
File: tailscale/rootfs/usr/bin/subnet-routes:1-2
Timestamp: 2025-11-06T10:55:55.062Z
Learning: In the hassio-addons/addon-tailscale project, utility scripts in `/usr/bin/` (like `subnet-routes`, `protect-subnet-routes`, `unprotect-subnet-routes`) are invoked from s6-overlay service scripts or NetworkManager dispatchers that already use `#!/command/with-contenv bashio`. These utilities inherit the environment from their parent processes and therefore use `#!/usr/bin/env bashio` rather than `#!/command/with-contenv bashio`.
Applied to files:
tailscale/config.yamltailscale/rootfs/etc/s6-overlay/s6-rc.d/tailscaled/run
📚 Learning: 2025-09-16T23:47:20.987Z
Learnt from: lmagyar
Repo: hassio-addons/addon-tailscale PR: 541
File: tailscale/config.yaml:30-37
Timestamp: 2025-09-16T23:47:20.987Z
Learning: In regex patterns, '.' matches any single character, so `local.subnets` in a regex would match `local_subnets`, `localXsubnets`, etc. The user lmagyar correctly pointed this out when I mistakenly identified it as a literal string mismatch.
Applied to files:
tailscale/config.yaml
📚 Learning: 2025-09-17T21:52:47.107Z
Learnt from: lmagyar
Repo: hassio-addons/addon-tailscale PR: 541
File: tailscale/rootfs/etc/s6-overlay/scripts/stage2_hook.sh:68-72
Timestamp: 2025-09-17T21:52:47.107Z
Learning: I made a critical regex error by claiming that the pattern "local.subnets" wouldn't match "local_subnets". In regex, '.' matches any single character including '_', so this pattern works correctly. The user lmagyar had to correct this same basic regex misunderstanding twice.
Applied to files:
tailscale/config.yaml
🔇 Additional comments (3)
tailscale/config.yaml (2)
31-32: Verify that advertise_exit_node and advertise_connector should default to true.Based on issue #572, "settings that require explicit action in the Tailscale admin UI and are not enabled by default in the stock client should be disabled by default in this add-on."
Both exit nodes and connectors require explicit setup and approval in the Tailscale admin console, and are not enabled by default in the stock Tailscale client. Setting these to
trueby default appears to contradict the stated objective of this PR.Please verify with the project maintainers whether these should default to
falseinstead:- advertise_exit_node: true + advertise_exit_node: false - advertise_connector: true + advertise_connector: false
44-61: Schema updates correctly enforce mandatory configuration.The schema changes properly make all fields required (except
exit_nodeon line 51), which aligns with the PR objective. The consistency between theoptionsdefaults andschemadefinitions is maintained.tailscale/rootfs/etc/s6-overlay/s6-rc.d/tailscaled/run (1)
26-29: Explicit true check correctly implements mandatory config behavior.The updated condition properly checks for an explicit
truevalue in the configuration, which aligns with the PR's shift from implicit defaults to explicit mandatory configuration. The comment accurately describes the behavior.
lmagyar
force-pushed
the
pr-mandatory-options
branch
2 times, most recently
from
112369e to
b266b6e
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@tailscale/config.yaml`:
- Line 32: The default for the Tailscale config currently sets
advertise_exit_node: true; change this default to false by updating the
advertise_exit_node setting in the Tailscale configuration (the
advertise_exit_node key) so exit-node advertising is disabled by default and
must be explicitly enabled by the user or admin via the Tailscale console.
- Line 33: The default for the app connector flag is incorrect: change the
advertise_connector setting from true to false in the configuration so the addon
does not advertise as an app connector by default; update any related defaults
or schema that reference advertise_connector and adjust tests or examples that
assume the old true default to use false or explicit opt-in instead.
b266b6e to
6902134
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lmagyar
force-pushed
the
pr-mandatory-options
branch
from
6902134 to
a220dba
Compare
Proposed Changes
This is a follow up after #463.
I've made all the optional config options mandatory, except exit node, becasue that is really an optional "string".
1 option was problematic: advertise_routes
Where:
I've resolved it with a default special value (documented):
Related Issues
fixes #572
Summary by CodeRabbit
New Features
Changes
Documentation