Vitest and other dependency upgrades#223
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated devDependency version ranges in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Updates the project’s dev tooling dependencies (primarily Vitest and related browser/coverage packages) and refreshes the pnpm lockfile to reflect the resolved dependency graph.
Changes:
- Bump
vitestand@vitest/*browser/coverage packages from4.1.4to4.1.5 - Bump
knipfrom6.5.0to6.6.0 - Update
pnpm-lock.yamlfor the new direct and transitive dependency resolutions
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates direct devDependency version ranges for Vitest-related packages and Knip. |
| pnpm-lock.yaml | Captures the resulting resolved versions, peer dep wiring, and transitive updates from the upgrades. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "jsonc-eslint-parser": "^3.1.0", | ||
| "knip": "^6.5.0", | ||
| "knip": "^6.6.0", | ||
| "oxfmt": "^0.46.0", |
There was a problem hiding this comment.
knip@^6.6.0 requires Node ^20.19.0 || >=22.12.0 (see pnpm-lock.yaml), but this repo advertises engines.node: ">=22". That allows Node 22.0–22.11, which will fail/warn on install. Please either bump engines.node to >=22.12.0 (or ^22.12.0) to match dependencies, or keep knip on a version that supports the currently declared engine range.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several development dependencies, primarily upgrading Vitest and its associated plugins from version 4.1.4 to 4.1.5. It also updates knip to version 6.6.0, which involves a shift in its internal dependencies, and includes minor version bumps for electron-to-chromium and flow-parser. I have no feedback to provide.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="package.json">
<violation number="1" location="package.json:157">
P2: `knip@^6.6.0` requires `node ^20.19.0 || >=22.12.0` (visible in the lockfile), but this repo declares `engines.node: ">=22"`. Node 22.0–22.11 satisfies the project constraint but fails knip's engine check. Bump `engines.node` to `">=22.12.0"` or pin knip to a version compatible with the current engine range.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "jsdom": "^29.0.2", | ||
| "jsonc-eslint-parser": "^3.1.0", | ||
| "knip": "^6.5.0", | ||
| "knip": "^6.6.0", |
There was a problem hiding this comment.
P2: knip@^6.6.0 requires node ^20.19.0 || >=22.12.0 (visible in the lockfile), but this repo declares engines.node: ">=22". Node 22.0–22.11 satisfies the project constraint but fails knip's engine check. Bump engines.node to ">=22.12.0" or pin knip to a version compatible with the current engine range.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 157:
<comment>`knip@^6.6.0` requires `node ^20.19.0 || >=22.12.0` (visible in the lockfile), but this repo declares `engines.node: ">=22"`. Node 22.0–22.11 satisfies the project constraint but fails knip's engine check. Bump `engines.node` to `">=22.12.0"` or pin knip to a version compatible with the current engine range.</comment>
<file context>
@@ -154,7 +154,7 @@
"jsdom": "^29.0.2",
"jsonc-eslint-parser": "^3.1.0",
- "knip": "^6.5.0",
+ "knip": "^6.6.0",
"oxfmt": "^0.46.0",
"oxlint": "^1.61.0",
</file context>
Summary by CodeRabbit
Chores
Note
Upgrade Vitest to 4.1.5 and knip to 6.6.0
Bumps
vitest,@vitest/browser-playwright,@vitest/browser-preview, and@vitest/coverage-v8from 4.1.4 to 4.1.5, andknipfrom 6.5.0 to 6.6.0. The pnpm-lock.yaml is regenerated to match.Macroscope summarized c09e1b6.