Skip to content

Vitest and other dependency upgrades #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hbmartin merged 1 commit into from
Apr 22, 2026
Merged

Vitest and other dependency upgrades #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,9 @@
"@types/react": "^19.2.14",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^6.0.1",
"@vitest/browser-playwright": "^4.1.4",
"@vitest/browser-preview": "^4.1.4",
"@vitest/coverage-v8": "^4.1.4",
"@vitest/browser-playwright": "^4.1.5",
"@vitest/browser-preview": "^4.1.5",
"@vitest/coverage-v8": "^4.1.5",
"@vitest/eslint-plugin": "^1.6.16",
"@welldone-software/why-did-you-render": "^10.0.1",
"class-variance-authority": "^0.7.1",
Expand All @@ -154,7 +154,7 @@
"jscpd": "^4.0.9",
"jsdom": "^29.0.2",
"jsonc-eslint-parser": "^3.1.0",
"knip": "^6.5.0",
"knip": "^6.6.0",

@cubic-dev-ai cubic-dev-ai Bot Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: knip@^6.6.0 requires node ^20.19.0 || >=22.12.0 (visible in the lockfile), but this repo declares engines.node: ">=22". Node 22.0–22.11 satisfies the project constraint but fails knip's engine check. Bump engines.node to ">=22.12.0" or pin knip to a version compatible with the current engine range.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 157:

<comment>`knip@^6.6.0` requires `node ^20.19.0 || >=22.12.0` (visible in the lockfile), but this repo declares `engines.node: ">=22"`. Node 22.0–22.11 satisfies the project constraint but fails knip's engine check. Bump `engines.node` to `">=22.12.0"` or pin knip to a version compatible with the current engine range.</comment>

<file context>
@@ -154,7 +154,7 @@
     "jsdom": "^29.0.2",
     "jsonc-eslint-parser": "^3.1.0",
-    "knip": "^6.5.0",
+    "knip": "^6.6.0",
     "oxfmt": "^0.46.0",
     "oxlint": "^1.61.0",
</file context>
Fix with Cubic

"oxfmt": "^0.46.0",
Comment on lines 156 to 158

Copilot AI Apr 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

knip@^6.6.0 requires Node ^20.19.0 || >=22.12.0 (see pnpm-lock.yaml), but this repo advertises engines.node: ">=22". That allows Node 22.0–22.11, which will fail/warn on install. Please either bump engines.node to >=22.12.0 (or ^22.12.0) to match dependencies, or keep knip on a version that supports the currently declared engine range.

Copilot uses AI. Check for mistakes.
"oxlint": "^1.61.0",
"oxlint-tsgolint": "^0.21.1",
Expand All @@ -169,7 +169,7 @@
"typescript": "^6.0.3",
"typescript-eslint": "^8.59.0",
"vite": "^8.0.9",
"vitest": "^4.1.4"
"vitest": "^4.1.5"
},
"peerDependencies": {
"class-variance-authority": ">=0.6.0",
Expand Down
Loading
Loading