add target platform for dockerfile, mutli arch image builds #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashu8912
force-pushed
the
multi-arch-image
branch
from
4a22a9c to
b0d1060
Compare
ashu8912
force-pushed
the
multi-arch-image
branch
from
5244146 to
7f7978c
Compare
Signed-off-by: ashu8912 <[email protected]>
ashu8912
force-pushed
the
multi-arch-image
branch
from
7f7978c to
9d3e4b4
Compare
illume
reviewed
Feb 17, 2025
| @@ -41,6 +50,7 @@ COPY --from=builder /headlamp-plugins/build/ /plugins/ | |||
|
|
|||
| LABEL org.opencontainers.image.source=https://github.com/headlamp-k8s/plugins | |||
| LABEL org.opencontainers.image.licenses=MIT | |||
| LABEL org.opencontainers.image.platform=$TARGETPLATFORM | |||
There was a problem hiding this comment.
What if TARGETPLATFORM is empty? Is this still valid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker buildx build \ --platform linux/amd64,linux/arm64 \ --build-arg PLUGIN=your-plugin-name \ -t your-image-name:tag \ --push \ .