Skip to content

app-catalog: Added app-catalog to artifact hub#497

Open
aadhil2k4 wants to merge 1 commit intoheadlamp-k8s:mainfrom
aadhil2k4:issue_412
Open

app-catalog: Added app-catalog to artifact hub#497
aadhil2k4 wants to merge 1 commit intoheadlamp-k8s:mainfrom
aadhil2k4:issue_412

Conversation

@aadhil2k4
Copy link
Contributor

fixes: #412

This PR adds initial Artifact Hub metadata for the App Catalog Headlamp plugin. This enables discovery of the plugin on Artifact Hub and allows it to be referenced from the Headlamp website.

@aadhil2k4
Copy link
Contributor Author

@illume Can you please check this PR and let me know if all the details are correct. Please let me know if I have made any mistake or missed something.

@illume
Copy link
Contributor

illume commented Jan 29, 2026

Thank you for this.

It's a bit more complicated, because we need to change the name of the plugin inside package.json to be in @headlamp-k8s/ namespace. Then we have to make sure we don't break anything with that change. Headlamp itself will need to be updated because it relies on using the current package name for downloading the plugin (there are some app-catalog scripts in the headlamp repo).

(There might be other places that need updating. But those are the only two places I can remember at the moment)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Artifact Hub metadata for the app-catalog plugin, enabling its discovery on Artifact Hub and integration with the Headlamp website. The metadata file follows the established pattern used by other Headlamp plugins.

Changes:

  • Added artifacthub-pkg.yml metadata file for the app-catalog plugin with version 0.8.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@illume
Copy link
Contributor

illume commented Jan 30, 2026

Please see the git commit guidelines and look at other git log messages.

Something like:

app-catalog: Add artifacthub-pkg.yml metadata

@aadhil2k4
Copy link
Contributor Author

Thank you for this.

It's a bit more complicated, because we need to change the name of the plugin inside package.json to be in @headlamp-k8s/ namespace. Then we have to make sure we don't break anything with that change. Headlamp itself will need to be updated because it relies on using the current package name for downloading the plugin (there are some app-catalog scripts in the headlamp repo).

(There might be other places that need updating. But those are the only two places I can remember at the moment)

@illume For the package namespace changes, should I implement them in this PR or raise a follow up PR as it requires updates in Headlamp repo as well?

@illume
Copy link
Contributor

illume commented Feb 1, 2026

I think in this PR and a headlamp repo or would be good.

@illume illume added the app-catalog app-catalog (helm charts) plugin related issues label Feb 1, 2026
Changes:
- Add artifacthub-pkg.yml for App Catalog plugin
- Rename package to @headlamp-k8s/app-catalog
- Regenerate package-lock.json after rename

Signed-off-by: Aadhil Ahamed <aadhil2k4@gmail.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 1 to 18641
@@ -18622,9 +18636,9 @@
}
},
"node_modules/yocto-queue": {
"version": "1.2.1",
"resolved": "https://registry.npmjs.org/yocto-queue/-/yocto-queue-1.2.1.tgz",
"integrity": "sha512-AyeEbWOu/TAXdxlV9wmGcR0+yh2j3vYPGOECcIj2S7MkrLyC7ne+oye2BKTItt0ii2PHk4cDy+95+LshzbXnGg==",
"version": "1.2.2",
"resolved": "https://registry.npmjs.org/yocto-queue/-/yocto-queue-1.2.2.tgz",
"integrity": "sha512-4LCcse/U2MHZ63HAJVE+v71o7yOdIe4cZ70Wpf8D/IyjDKYQLV5GD46B+hSTjJsvV5PztjvHoU580EftxjDZFQ==",
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package-lock.json contains extensive dependency updates (Babel, esbuild, rollup, Storybook, TypeScript ESLint plugins, and many others) that appear unrelated to adding Artifact Hub metadata. These updates seem to have been triggered by running npm install. Consider whether these dependency updates should be:

  1. Included in this PR (if intentional and tested)
  2. Split into a separate PR focused on dependency updates
  3. Reverted if they were unintentional

The package-lock.json changes should ideally be minimal for this PR, only updating the package name from "app-catalog" to "@headlamp-k8s/app-catalog" without upgrading all dependencies, unless the dependency updates are intentional and have been tested.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@illume I regenerated the package-lock.json after updating the package. Isnt it the correct way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app-catalog app-catalog (helm charts) plugin related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

app-catalog: Add app-catalog to artifact hub

2 participants