app-catalog: Added app-catalog to artifact hub#497
app-catalog: Added app-catalog to artifact hub#497aadhil2k4 wants to merge 1 commit intoheadlamp-k8s:mainfrom
Conversation
|
@illume Can you please check this PR and let me know if all the details are correct. Please let me know if I have made any mistake or missed something. |
|
Thank you for this. It's a bit more complicated, because we need to change the name of the plugin inside package.json to be in (There might be other places that need updating. But those are the only two places I can remember at the moment) |
There was a problem hiding this comment.
Pull request overview
This PR adds Artifact Hub metadata for the app-catalog plugin, enabling its discovery on Artifact Hub and integration with the Headlamp website. The metadata file follows the established pattern used by other Headlamp plugins.
Changes:
- Added
artifacthub-pkg.ymlmetadata file for the app-catalog plugin with version 0.8.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Please see the git commit guidelines and look at other git log messages. Something like:
|
@illume For the package namespace changes, should I implement them in this PR or raise a follow up PR as it requires updates in Headlamp repo as well? |
|
I think in this PR and a headlamp repo or would be good. |
Changes: - Add artifacthub-pkg.yml for App Catalog plugin - Rename package to @headlamp-k8s/app-catalog - Regenerate package-lock.json after rename Signed-off-by: Aadhil Ahamed <aadhil2k4@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -18622,9 +18636,9 @@ | |||
| } | |||
| }, | |||
| "node_modules/yocto-queue": { | |||
| "version": "1.2.1", | |||
| "resolved": "https://registry.npmjs.org/yocto-queue/-/yocto-queue-1.2.1.tgz", | |||
| "integrity": "sha512-AyeEbWOu/TAXdxlV9wmGcR0+yh2j3vYPGOECcIj2S7MkrLyC7ne+oye2BKTItt0ii2PHk4cDy+95+LshzbXnGg==", | |||
| "version": "1.2.2", | |||
| "resolved": "https://registry.npmjs.org/yocto-queue/-/yocto-queue-1.2.2.tgz", | |||
| "integrity": "sha512-4LCcse/U2MHZ63HAJVE+v71o7yOdIe4cZ70Wpf8D/IyjDKYQLV5GD46B+hSTjJsvV5PztjvHoU580EftxjDZFQ==", | |||
There was a problem hiding this comment.
The package-lock.json contains extensive dependency updates (Babel, esbuild, rollup, Storybook, TypeScript ESLint plugins, and many others) that appear unrelated to adding Artifact Hub metadata. These updates seem to have been triggered by running npm install. Consider whether these dependency updates should be:
- Included in this PR (if intentional and tested)
- Split into a separate PR focused on dependency updates
- Reverted if they were unintentional
The package-lock.json changes should ideally be minimal for this PR, only updating the package name from "app-catalog" to "@headlamp-k8s/app-catalog" without upgrading all dependencies, unless the dependency updates are intentional and have been tested.
There was a problem hiding this comment.
@illume I regenerated the package-lock.json after updating the package. Isnt it the correct way?
fixes: #412
This PR adds initial Artifact Hub metadata for the App Catalog Headlamp plugin. This enables discovery of the plugin on Artifact Hub and allows it to be referenced from the Headlamp website.