prometheus: Add support for external Prometheus URLs#508
Conversation
skoeva
force-pushed
the
prometheus-external-url
branch
from
06fbd0d to
180c437
Compare
skoeva
force-pushed
the
prometheus-external-url
branch
2 times, most recently
from
0fbac61 to
8835ec2
Compare
skoeva
force-pushed
the
prometheus-external-url
branch
2 times, most recently
from
a6a8d1f to
77dd54b
Compare
skoeva
force-pushed
the
prometheus-external-url
branch
from
77dd54b to
4b45b94
Compare
|
code looks okay. I'm okay with merging it once someone manually tests this |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skoeva
force-pushed
the
prometheus-external-url
branch
2 times, most recently
from
bd16b4a to
757f40b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skoeva
force-pushed
the
prometheus-external-url
branch
3 times, most recently
from
22a8e56 to
406fd8d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hii @skoeva and @Tusharjamdade can you look at some of these comments from copilot review and address them. Thank you. |
|
I tried this PR and got CORS issue on development when using external prometheus URL |
skoeva
force-pushed
the
prometheus-external-url
branch
from
406fd8d to
7b61438
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Tusharjamdade <tusharnjamdade@gmail.com> Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva
force-pushed
the
prometheus-external-url
branch
from
7b61438 to
b1bddd9
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4 participants
These changes allow configuring Prometheus using a full HTTP/HTTPS URL in addition to
namespace/service:port. This enables connecting clusters to external or shared Prometheus instances, and keeps existing k8s service-based configuration working.Fixes: #377, follow-up from #494