Skip to content

Code standard #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Code standard #189

wants to merge 6 commits into from

Conversation

flx-sta
Copy link
Collaborator

@flx-sta flx-sta commented Apr 14, 2021

Code-Style-Standard suggestion

I've focued mostly on major stuff.

The code-style file (for IntelliJ) can be found here:

📝 peregrine-cms.codestyle.intellij.xml


Broad Summary

Java

  • Identation: 4
  • method chaining: chop
  • 2 blank lines after imports
  • space after if/for/while etc.
  • no space after function.

Java-/Typescript

  • Identation: 4
  • Single-quotes enforced
  • Semicolon enforced
  • Trailing comma: add on multi-line
  • method chaining: chop
  • 2 blank lines after imports
  • space after if/for/while etc.
  • no space after function

XML

  • align attributes
  • align Text
  • no text-wrap

@flx-sta flx-sta self-assigned this Apr 14, 2021
@flx-sta flx-sta added help wanted Extra attention is needed question Further information is requested Release 1.0.0 verify and removed Release 1.0.0 labels Apr 14, 2021
@reusr1
Copy link
Contributor

reusr1 commented Apr 14, 2021

@Felix-Puetz as an alternative I did a second pr ( #190 ) using prettier.io

@reggie7
Copy link
Contributor

reggie7 commented Apr 26, 2021

@Felix-Puetz as an alternative I did a second pr ( #190 ) using prettier.io

@reusr1 any standard is fine, as long as there is one at the end :)

@flx-sta flx-sta removed their assignment Aug 4, 2023
@flx-sta flx-sta closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants