Skip to content

added prettier.io as an experiment for code formatting #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop-sling12
Choose a base branch
from

Conversation

reusr1
Copy link
Contributor

@reusr1 reusr1 commented Apr 14, 2021

  • code style format through prettier*

as an alternative to #189 I tried to use prettier (using their defaults)

npx prettier --write .

observation: if you run percli hatch "*" we of course revert a lot of code back to a style that is not desired

@reusr1 reusr1 mentioned this pull request Apr 14, 2021
@cmrockwell
Copy link
Collaborator

This PR seems to have the outcome of standards applied committed along with the added config file .prettierrc.json
It would be nicer to commit the changes to the build and new files like .prettierrc.json separated from the work of applying the standards. Maybe something like https://github.com/HubSpot/prettier-maven-plugin ?

@reusr1
Copy link
Contributor Author

reusr1 commented Apr 28, 2021

This PR seems to have the outcome of standards applied committed along with the added config file .prettierrc.json
It would be nicer to commit the changes to the build and new files like .prettierrc.json separated from the work of applying the standards. Maybe something like https://github.com/HubSpot/prettier-maven-plugin ?

@cmrockwell the PR was mostly to illustrate the result of prettier.io and if that would be acceptable by others or if we want to use what @Felix-Puetz proposed in #189

@reggie7 reggie7 self-requested a review May 12, 2021 09:16
@reusr1
Copy link
Contributor Author

reusr1 commented May 12, 2021

looking at the conflicts and the output a bit more it seems we first have to fix the output from our code generator to work better with enabling prettier.io

also wondering if we should move to 2 spaces instead of 4 for the tabs

@flx-sta
Copy link
Collaborator

flx-sta commented May 12, 2021

Why don't we just start with something?`and keep on going from there.
It's just code-format..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants