Update hotspotsController.js to return ordered list of hotspots#4
Open
jmarcelino wants to merge 1 commit intohelium:mainfrom
Open
Update hotspotsController.js to return ordered list of hotspots#4jmarcelino wants to merge 1 commit intohelium:mainfrom
jmarcelino wants to merge 1 commit intohelium:mainfrom
Conversation
Order hotspots by id for paginating
tyler-whitman
approved these changes
Apr 13, 2022
Contributor
tyler-whitman
left a comment
There was a problem hiding this comment.
Looks good to me, did you get a chance to test this out? What order were they in before?
Author
|
Thanks! I did test it out in our instance. Without the explicit order findAll seems to return data in random order and thus the pagination result would also be random, for example if you request page 1 multiple times you get a different set of entries each time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Order hotspots by id when returning all hotspots
This is particularly important for paginating otherwise the pagination will not be consistent across page requests, ie requesting the same page number will return different, random, hotspots