Skip to content

fix: allow completion of ignored files for some Typable commands.#12729

Open
kumawatdarshan wants to merge 1 commit intohelix-editor:masterfrom
kumawatdarshan:open-ignored
Open

fix: allow completion of ignored files for some Typable commands.#12729
kumawatdarshan wants to merge 1 commit intohelix-editor:masterfrom
kumawatdarshan:open-ignored

Conversation

@kumawatdarshan
Copy link
Contributor

Changes behaviour for :open, :vsplit :hsplit.

closes: #12357
supersedes: #12418

@kumawatdarshan kumawatdarshan changed the title fix: allow completion for ignored files for Typable commands. fix: allow completion of ignored files for some Typable commands. Jan 30, 2025
@CalebLarsen
Copy link
Contributor

It seems that the desired default behavior in every usage of completers::filename is for .gitignore to not be used.

I think that that means it makes more sense to change the default in ui/mod.rs from passing true to passing false rather than changing every call site of the filename function.

@kumawatdarshan
Copy link
Contributor Author

It seems that the desired default behavior in every usage of completers::filename is for .gitignore to not be used.

Sounds reasonable. I made that change.

This time, It changes the behaviour for several completers:
[open, write, write!, write-buffer-close, write-buffer-close!, write-quit, write-quit!, vsplit, hsplit, move, read, cd]

iniw added a commit to iniw/helix that referenced this pull request Oct 26, 2025
change completer default in ui/mod
iniw added a commit to iniw/helix that referenced this pull request Oct 27, 2025
change completer default in ui/mod
iniw added a commit to iniw/helix that referenced this pull request Oct 27, 2025
change completer default in ui/mod
iniw added a commit to iniw/helix that referenced this pull request Oct 27, 2025
change completer default in ui/mod
iniw pushed a commit to iniw/helix that referenced this pull request Oct 27, 2025
change completer default in ui/mod
iniw pushed a commit to iniw/helix that referenced this pull request Nov 3, 2025
change completer default in ui/mod
iniw pushed a commit to iniw/helix that referenced this pull request Dec 4, 2025
change completer default in ui/mod
iniw pushed a commit to iniw/helix that referenced this pull request Dec 4, 2025
change completer default in ui/mod
iniw pushed a commit to iniw/helix that referenced this pull request Dec 30, 2025
change completer default in ui/mod
iniw pushed a commit to iniw/helix that referenced this pull request Dec 30, 2025
change completer default in ui/mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support tab-complete when manually opening files excluded through gitignore

2 participants