Fix wqa! message #14267
Fix wqa! message #14267
Conversation
Thanks! Anyone else able to take a look so this can be landed please? |
helix-term/src/commands/typed.rs
Outdated
| name: "write-quit-all!", | ||
| aliases: &["wqa!", "xa!"], | ||
| doc: "Write changes from all buffers to disk and close all views forcefully (ignoring unsaved changes).", | ||
| doc: "Forcefully write changes from all buffers to disk, creating necessary subdirectories, and close all views.", |
There was a problem hiding this comment.
force_write_all_quit also forcefully closes all views: both the write and the quit are forceful. For example if you open a scratch buffer and make changes without writing them to a file, :wqa will not quit while :wqa! will
There was a problem hiding this comment.
I think the original message is still a bit unclear in regards to changes being made in saved buffers being written forcefully. When I first read the message, I understood it as implying that changes are not saved forcefully. Maybe a new version could be: Forcefully write changes from all buffers to disk, creating necessary subdirectories, and close all views (ignoring unsaved changes).?
There was a problem hiding this comment.
Done 🙌 thanks for the feedback
3 participants
Hi! I noticed that the message for the
:wqa!command is contradictory. It states that we ignore unsaved changes, but the command actually forces everything to be saved. This is incorrect. This PR updates the message to make this clear.