Skip to content

Add omnibase move_by translation and rotation#40

Open
hello-lamsey wants to merge 3 commits into
jazzyfrom
feature/omnibase_move_to_pos
Open

Add omnibase move_by translation and rotation#40
hello-lamsey wants to merge 3 commits into
jazzyfrom
feature/omnibase_move_to_pos

Conversation

@hello-lamsey

@hello-lamsey hello-lamsey commented Jul 10, 2026

Copy link
Copy Markdown
Contributor
  • Adds ability to command XY omnibase movements
  • Adds ability to command theta omnibase movements
  • Checks whether rotation and translation are simultaneously commanded (disallowed) in callback_group.activate()

@hello-lamsey
hello-lamsey requested a review from hello-binit July 10, 2026 15:55
@hello-lamsey

hello-lamsey commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

@hello-binit I am not 100% sure that this implementation will correctly block send_goal_future.done() from returning correctly, looking into it now

@hello-lamsey

hello-lamsey commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

OK, I think this fixes it. When do we want to move the did_start_moving flags to stretch4_body?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hello-binit hello-binit Awaiting requested review from hello-binit

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hello-lamsey @hello-garv