Set lease holder to None, priority to 0, and routine_active to False on lease holder expiry#43
Open
hello-garv wants to merge 1 commit into
Open
Conversation
…on lease holder expiry
hello-lamsey
approved these changes
Jul 16, 2026
hello-lamsey
left a comment
hello-lamsey
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Does lease_holder=None behave safely elsewhere in the driver? Your testing yesterday seemed to indicate that behavior was fine; just double checking
Contributor
Author
Good question, web teleop is the only subscriber to the topic right now, so changes should be isolated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sbs lease holder is not cleared after expiration time, it is up to the consumer to check if the expiration has passed. This PR updates the name to none and priority to 0 to reduce logic overhead for topic subscribers.